Обсуждение: Re: [COMMITTERS] pgsql: Rename the members of CommandDest enum so
Marc G. Fournier wrote: > > Is this an appropriate commit for post-Beta? Does it fix a critical bug > that will prevent a release from happening? :( Well, I asked -hackers before committing, and there were no objections, plus there were a couple of messages that weren't actual encouragements but I took as sign of approval. The patch itself is pretty innocuous. I will keep an eye on the buildfarm in case it causes any problems. It doesn't fix a bug in Pg proper, but it allows PL/php to build. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Marc G. Fournier wrote:
>> Is this an appropriate commit for post-Beta? Does it fix a critical bug
>> that will prevent a release from happening? :(
> Well, I asked -hackers before committing, and there were no objections,
> plus there were a couple of messages that weren't actual encouragements
> but I took as sign of approval.
Yeah, I would have told him "no" if I thought there were any risk of
breaking things, but renaming some constants seems a pretty safe
activity --- the compiler will catch any overlooked cases.
regards, tom lane