Обсуждение: XLogDir

A recent change made XLogDir dynamically sized.  There was a question of
whether this was a good idea since there are lots of other places that
use MAXPGPATH.

I have now found that pg_resetxlog doesn't compile anymore because
XLogDir is a char* now instead of a char[].

Should I fix pg_resetxlog or revert the XLogDir change in the backend.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> A recent change made XLogDir dynamically sized.  There was a question of
> whether this was a good idea since there are lots of other places that
> use MAXPGPATH.

> I have now found that pg_resetxlog doesn't compile anymore because
> XLogDir is a char* now instead of a char[].

> Should I fix pg_resetxlog or revert the XLogDir change in the backend.

Revert.  The XLogDir change was incomplete and basically useless to
start with ...
        regards, tom lane

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > A recent change made XLogDir dynamically sized.  There was a question of
> > whether this was a good idea since there are lots of other places that
> > use MAXPGPATH.
> 
> > I have now found that pg_resetxlog doesn't compile anymore because
> > XLogDir is a char* now instead of a char[].
> 
> > Should I fix pg_resetxlog or revert the XLogDir change in the backend.
> 
> Revert.  The XLogDir change was incomplete and basically useless to
> start with ...

Yea, but it was tied into the PGXLOG commit.  Thomas, what are we doing
with that?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 

> > Revert.  The XLogDir change was incomplete and basically useless to
> > start with ...
> Yea, but it was tied into the PGXLOG commit.  Thomas, what are we doing
> with that?

Why ask me?
                 - Thomas

Thomas Lockhart wrote:
> > > Revert.  The XLogDir change was incomplete and basically useless to
> > > start with ...
> > Yea, but it was tied into the PGXLOG commit.  Thomas, what are we doing
> > with that?
> 
> Why ask me?

Sorry, I mean XLOGDIR.  Somehow I kept saying PGXLOG.  Anyway, it is all
out and we can re-add as needed.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073