Обсуждение: datetime.c in v6.4.3beta2 ...

I just built a v6.4.3beta2 tar file, hoping to try and get it released
RSN, and am doing a test built on my machine...it fails at datetime.c,
line 109, with a reference to day_tab[] ... 

day_tab is 'declared' at line 31 of that same file, but that section of
code is #ifdef 0'd out ...

Looks like something that Thomas added:

hub# cvs diff -r1.25.2.1 -r1.25.2.2 datetime.c | less
Index: datetime.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/backend/utils/adt/datetime.c,v
retrieving revision 1.25.2.1
retrieving revision 1.25.2.2
diff -r1.25.2.1 -r1.25.2.2
10c10
<  *      $Header:
/usr/local/cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 
1.25.2.1 1998/12/31 16:34:47 thomas Exp $
---
>  *      $Header:
/usr/local/cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 
1.25.2.2 1999/02/13 05:59:34 thomas Exp $
30c30
< 
---
> #if 0
35a36
> #endif
101a103
> #if 0
105a108
> #endif


Marc G. Fournier                                
Systems Administrator @ hub.org 
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org 

> I just built a v6.4.3beta2 tar file, hoping to try and get it released
> RSN, and am doing a test built on my machine...it fails at datetime.c,
> line 109, with a reference to day_tab[] ...
> Looks like something that Thomas added:

Yeah, Tom Lane already mentioned it. My 'net access was down this
morning; will look at it this evening. Sorry...
                   - Tom

On Wed, 3 Mar 1999, Thomas G. Lockhart wrote:

> > I just built a v6.4.3beta2 tar file, hoping to try and get it released
> > RSN, and am doing a test built on my machine...it fails at datetime.c,
> > line 109, with a reference to day_tab[] ...
> > Looks like something that Thomas added:
> 
> Yeah, Tom Lane already mentioned it. My 'net access was down this
> morning; will look at it this evening. Sorry...

S'alright, must have missed Tom's :(

Marc G. Fournier                                
Systems Administrator @ hub.org 
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org 

> > > I just built a v6.4.3beta2 tar file, hoping to try and get it 
> > > released RSN, and am doing a test built on my machine...it fails 
> > > at datetime.c, line 109, with a reference to day_tab[] ...
> > > Looks like something that Thomas added:

I had patched my tree on postgresql.org, but had neglected to commit the
patch for dt.h. afaik it is now OK, but I was not able to get a
regression test since REL6_4 hangs while building on my system due to
tcl scripting problems.

I can work around that if necessary, but we *really* should have a
system that manages to build cleanly...

Sorry for the dt.h omission.
                        - Tom

On Wed, 3 Mar 1999, Thomas G. Lockhart wrote:

> > > > I just built a v6.4.3beta2 tar file, hoping to try and get it 
> > > > released RSN, and am doing a test built on my machine...it fails 
> > > > at datetime.c, line 109, with a reference to day_tab[] ...
> > > > Looks like something that Thomas added:
> 
> I had patched my tree on postgresql.org, but had neglected to commit the
> patch for dt.h. afaik it is now OK, but I was not able to get a
> regression test since REL6_4 hangs while building on my system due to
> tcl scripting problems.
> 
> I can work around that if necessary, but we *really* should have a
> system that manages to build cleanly...

Will put some time into this later this evening...thanks for fixign the
datetime.c stuff :)

Marc G. Fournier                                
Systems Administrator @ hub.org 
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org