Обсуждение: RE: [HACKERS] DestroyDB Patch *** Update
Hi there, Here is the proper diff -c patch file for the previously mentionned patch : *** junkfilter_patch.txt Fri Oct 23 10:26:14 1998 --- patch-fm Thu Oct 22 09:17:34 1998 *************** *** 29,35 **** JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList); estate->es_junkFilter =j; + ! + tupType = j->jf_cleanTupType; /* Added by daveh@insightdist.com 5/20/98 */ } else estate->es_junkFilter = NULL; --- 29,35 ---- JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList); estate->es_junkFilter =j; + ! + if (operation != CMD_DELETE) {tupType = j->jf_cleanTupType;} /* Added by daveh@insightdist.com 5/20/98modified by Francois Machabee 10/21/1998 */ } else estate->es_junkFilter = NULL; François Machabée Nexus Informatique & Marketing, Inc. / Nexus Information Systems & Marketing, Inc. WWW: Http://www.nexus-is.qc.ca Email: mailto:francois@nexus-is.qc.ca -----Original Message----- From: Thomas G. Lockhart [SMTP:lockhart@alumni.caltech.edu] Sent: Friday, October 23, 1998 9:51 AM To: Francois Machabee; David Hartwig Cc: 'pgsql-hackers@postgresql.org' Subject: Re: [HACKERS] DestroyDB Patch *** Update > Let me start by congratulating everyone involved in the Postgresql > project for a job well done. I have thoroughly researched the bug in > 6.3.2 with the ODBC ORDER BY as well as the patch supplied by insight > for the backend. With the help of the debug information provided by > another poster I have devised a simple (maybe stupid) fix which seems > to have fixed all the problems related to destroydb and delete from > crashing the backend. The change to the patch file is simple : Could you please send a new patch file? Use "diff -c" to generate it... David, have you had a chance to look at this? Is it still a problem? - Tom
[Charset iso-8859-1 unsupported, filtering to ASCII...] > Hi there, > > Here is the proper diff -c patch file for the previously mentionned patch : > > *** junkfilter_patch.txt Fri Oct 23 10:26:14 1998 > --- patch-fm Thu Oct 22 09:17:34 1998 > *************** > *** 29,35 **** > JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList); > estate->es_junkFilter = j; > + > ! + tupType = j->jf_cleanTupType; /* Added by daveh@insightdist.com 5/20/98 */ > } > else > estate->es_junkFilter = NULL; > --- 29,35 ---- > JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList); > estate->es_junkFilter = j; > + > ! + if (operation != CMD_DELETE) {tupType = j->jf_cleanTupType;} /* Added by daveh@insightdist.com 5/20/98modified by Francois Machabee 10/21/1998 */ > } > else > estate->es_junkFilter = NULL; I can't apply this one either. First, it is not a patch, but a patch on a patch. The line that starts "! +" says that. Second, am I supposed to guess what file this is supposed to be applied to? I can't figure it out, but it could be execMain.c. And third, it does not match any code in the executor in the 6.4 beta tree. Please send a patch that can apply against the 6.4 beta on ftp.postgresql.org. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026