Обсуждение: Broken makefile for docs

golem$ cd doc
golem$ make install
make all
make[1]: Entering directory `/opt/postgres/pgsql/doc'
rm -rf ./admin unpacked/admin
if test ! -d unpacked/admin ; then mkdir unpacked/admin ; fi
mkdir: cannot make directory `unpacked/admin': No such file or directory
make[1]: *** [admin] Error 1
make[1]: Leaving directory `/opt/postgres/pgsql/doc'
make: *** [install] Error 2

What is "unpacked"? And why does the docs Makefile want it??

                     - Tom

On Mon, 13 Apr 1998, Thomas G. Lockhart wrote:

> golem$ cd doc
> golem$ make install
> make all
> make[1]: Entering directory `/opt/postgres/pgsql/doc'
> rm -rf ./admin unpacked/admin
> if test ! -d unpacked/admin ; then mkdir unpacked/admin ; fi
> mkdir: cannot make directory `unpacked/admin': No such file or directory
> make[1]: *** [admin] Error 1
> make[1]: Leaving directory `/opt/postgres/pgsql/doc'
> make: *** [install] Error 2
>
> What is "unpacked"? And why does the docs Makefile want it??

> cvs diff -r1.5 -r1.6 Makefile
Index: Makefile
===================================================================
RCS file: /usr/local/cvsroot/pgsql/doc/Makefile,v
retrieving revision 1.5
retrieving revision 1.6
diff -r1.5 -r1.6
11c11
< #    $Header: /usr/local/cvsroot/pgsql/doc/Makefile,v 1.5 1998/03/15
07:37:51 scrappy Exp $
---
> #    $Header: /usr/local/cvsroot/pgsql/doc/Makefile,v 1.6 1998/04/06
01:35:16 momjian Exp $
15c15
< PGDOCS= /usr/local/cdrom/docs
---
> PGDOCS= unpacked


Changes for DESTDIR/linux that Bruce committed, but what I had before that
would have broken on your machine also, I fear :)


Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org

> > What is "unpacked"? And why does the docs Makefile want it??
> < PGDOCS= /usr/local/cdrom/docs
> ---
> > PGDOCS= unpacked
>
> Changes for DESTDIR/linux that Bruce committed, but what I had before
> that would have broken on your machine also, I fear :)

Well, /usr/local/cdrom/docs doesn't quite work either :)

Will revert to the original stuff unless there is a "grand scheme" for
this. We're now using POSTGRESDIR for the DESTDIR function?

                       - Tom

On Mon, 13 Apr 1998, Thomas G. Lockhart wrote:

> > > What is "unpacked"? And why does the docs Makefile want it??
> > < PGDOCS= /usr/local/cdrom/docs
> > ---
> > > PGDOCS= unpacked
> >
> > Changes for DESTDIR/linux that Bruce committed, but what I had before
> > that would have broken on your machine also, I fear :)
>
> Well, /usr/local/cdrom/docs doesn't quite work either :)

    Nope, that was just me working on the cd's :)  I must have done a
commit without realizing the change...

> Will revert to the original stuff unless there is a "grand scheme" for
> this. We're now using POSTGRESDIR for the DESTDIR function?

    No, I believe we got rid of the DESTDIR functionality altogether
as it was unrequired...

>
> golem$ cd doc
> golem$ make install
> make all
> make[1]: Entering directory `/opt/postgres/pgsql/doc'
> rm -rf ./admin unpacked/admin
> if test ! -d unpacked/admin ; then mkdir unpacked/admin ; fi
> mkdir: cannot make directory `unpacked/admin': No such file or directory
> make[1]: *** [admin] Error 1
> make[1]: Leaving directory `/opt/postgres/pgsql/doc'
> make: *** [install] Error 2
>
> What is "unpacked"? And why does the docs Makefile want it??

Oops, I installed that patch.  Someone supplied a patch to put it in a
subdirectory called 'unpacked' rather than a hard-coded patch.  I think
it was the Linux Redhat guy.  Guess he forgot to create the directory.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)