Re: [INTERFACES] libpq sockets on win32

Поиск
Список
Период
Сортировка
Искать

Re: [INTERFACES] libpq sockets on win32

От:
Bruce Momjian <pgman@candle.pha.pa.us>
Дата:
> I found that sending more than 16k of data in a SQL statement caused a
> problem.  I was using PyGreSQL but narrowed the error down to
> "\postgresql-7.1.2\src\interfaces\libpq\fe-misc.c" pqReadData() and
> pqFlush().  After some poking around, it looked like recv was setting
> errno to ENOENT for some reason.  I figured out why today.  Win32
> sockets don't set errno at all.  ENOENT was just left in errno from
> some earlier call.
> 
> This article describes the problem and work around.
> http://msdn.microsoft.com/library/psdk/winsock/ovrvw3_26ia.htm

I can't read that web site under Netscape.

> I haven't done much C coding in a few years and don't want to break
> other code by blindly doing:
> 
> #define errno WSAGetLastError

If I could read it, I think I could fix it.  Please send it in some
readable format.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: [INTERFACES] libpq sockets on win32

От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Bruce Momjian  writes:
>> This article describes the problem and work around.
>> http://msdn.microsoft.com/library/psdk/winsock/ovrvw3_26ia.htm

> I can't read that web site under Netscape.

Comes up fine for me (maybe you need to turn off Javascript?)

However, the advice on it seems to be written by someone who does not
know the difference between a variable and a function :-(.  Read with
a large grain of salt.

We already have a couple of #ifdef'd usages of WSAGetLastError() in
libpq, but it's quite unclear which other references to errno might
need to be changed.  A blanket replacement of errno would certainly
break things.

			regards, tom lane

Re: [INTERFACES] libpq sockets on win32

От:
Bruce Momjian <pgman@candle.pha.pa.us>
Дата:
> Bruce Momjian  writes:
> >> This article describes the problem and work around.
> >> http://msdn.microsoft.com/library/psdk/winsock/ovrvw3_26ia.htm
> 
> > I can't read that web site under Netscape.
> 
> Comes up fine for me (maybe you need to turn off Javascript?)

Thanks, that fixed it.

> However, the advice on it seems to be written by someone who does not
> know the difference between a variable and a function :-(.  Read with
> a large grain of salt.
> 
> We already have a couple of #ifdef'd usages of WSAGetLastError() in
> libpq, but it's quite unclear which other references to errno might
> need to be changed.  A blanket replacement of errno would certainly
> break things.

That's why I recommended brackets of #define/#undef around tests of
socket errno's.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
FAQ