Update needed for documentation

Поиск
Список
Период
Сортировка
Искать

Update needed for documentation

От:
Justin Clift <justin@postgresql.org>
Дата:
Hi all,

Spotted the following line in the 7.1 Interactive docs, not sure if it's
been updated :

"As of the current release (v7.0), STATEMENT triggers are not
implemented."

It's in the PostgreSQL Doc page which explains "CREATE TRIGGER".

Regards and best wishes,

Justin Clift

Re: Update needed for documentation

От:
Bruce Momjian <pgman@candle.pha.pa.us>
Дата:
> Hi all,
> 
> Spotted the following line in the 7.1 Interactive docs, not sure if it's
> been updated :
> 
> "As of the current release (v7.0), STATEMENT triggers are not
> implemented."
> 
> It's in the PostgreSQL Doc page which explains "CREATE TRIGGER".

I see in command/trigger.c:

    if (stmt->row)
        TRIGGER_SETT_ROW(tgtype);
    else
        elog(ERROR, "CreateTrigger: STATEMENT triggers are unimplemented, yet");

We have per-row triggers but not per-statement triggers.  Seems we use
RULEs for those.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Re: Update needed for documentation

От:
Bruce Momjian <pgman@candle.pha.pa.us>
Дата:

I understand now, and you are correct.  There is no reason to mention
the release version in the docs, in most cases.  Attached patch applied.

Thanks.



> Hi Bruce,
> 
> My point was to get the documentation updated, not anything else.  Probably 
> we should bump the statement in the doc's to say "7.1.2".
> 
> :-)
> 
> Regards and best wishes,
> 
> Justin Clift
> 
> On Tuesday 05 June 2001 05:32, you wrote:
> > > Hi all,
> > >
> > > Spotted the following line in the 7.1 Interactive docs, not sure if it's
> > > been updated :
> > >
> > > "As of the current release (v7.0), STATEMENT triggers are not
> > > implemented."
> > >
> > > It's in the PostgreSQL Doc page which explains "CREATE TRIGGER".
> >
> > I see in command/trigger.c:
> >
> >     if (stmt->row)
> >         TRIGGER_SETT_ROW(tgtype);
> >     else
> >         elog(ERROR, "CreateTrigger: STATEMENT triggers are unimplemented,
> > yet");
> >
> > We have per-row triggers but not per-statement triggers.  Seems we use
> > RULEs for those.
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: doc/src/sgml/ref/create_trigger.sgml
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/ref/create_trigger.sgml,v
retrieving revision 1.13
diff -c -r1.13 create_trigger.sgml
*** doc/src/sgml/ref/create_trigger.sgml	2001/05/27 09:59:28	1.13
--- doc/src/sgml/ref/create_trigger.sgml	2001/06/10 03:44:14
***************
*** 150,156 ****
      Only the relation owner may create a trigger on this relation.
     
     
!     As of the current release (v7.0), STATEMENT triggers are not implemented.
     
     
      Refer to DROP TRIGGER for information on how to 
--- 150,156 ----
      Only the relation owner may create a trigger on this relation.
     
     
!     As of the current release, STATEMENT triggers are not implemented.
     
     
      Refer to DROP TRIGGER for information on how to 
Index: doc/src/sgml/ref/psql-ref.sgml
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/ref/psql-ref.sgml,v
retrieving revision 1.55
diff -c -r1.55 psql-ref.sgml
*** doc/src/sgml/ref/psql-ref.sgml	2001/05/28 04:27:17	1.55
--- doc/src/sgml/ref/psql-ref.sgml	2001/06/10 03:44:16
***************
*** 1051,1057 ****
  
  	
  	
! 	As of psql version 7.0 it is no longer
  	necessary to save the command history, since that will be done
  	automatically on program termination. The history is
  	also loaded automatically every time psql
--- 1051,1057 ----
  
  	
  	
! 	In the current version, it is no longer
  	necessary to save the command history, since that will be done
  	automatically on program termination. The history is
  	also loaded automatically every time psql
***************
*** 1579,1585 ****
        
  
        
!       As of version 7.0, psql automatically issues a
        password prompt whenever the backend requests password authentication.
        Because this is currently based on a hack, the automatic
        recognition might mysteriously fail, hence this option to force a prompt.
--- 1579,1585 ----
        
  
        
!       In the current version, psql automatically issues a
        password prompt whenever the backend requests password authentication.
        Because this is currently based on a hack, the automatic
        recognition might mysteriously fail, hence this option to force a prompt.
Index: doc/src/sgml/ref/select.sgml
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/ref/select.sgml,v
retrieving revision 1.42
diff -c -r1.42 select.sgml
*** doc/src/sgml/ref/select.sgml	2001/05/30 04:32:30	1.42
--- doc/src/sgml/ref/select.sgml	2001/06/10 03:44:17
***************
*** 122,129 ****
  	table is scanned.  If ONLY is not specified, the table and all its
  	descendant tables (if any) are scanned.  * can be appended to the
  	table name to indicate that descendant tables are to be scanned,
! 	but as of Postgres 7.1 this is the default
! 	behavior.  (In releases before 7.1, ONLY was the default behavior.)
         
        
       
--- 122,129 ----
  	table is scanned.  If ONLY is not specified, the table and all its
  	descendant tables (if any) are scanned.  * can be appended to the
  	table name to indicate that descendant tables are to be scanned,
! 	but in the current version, this is the default behavior.
! 	(In releases before 7.1, ONLY was the default behavior.)
         
        
       
Index: doc/src/sgml/ref/create_trigger.sgml
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/ref/create_trigger.sgml,v
retrieving revision 1.13
diff -c -r1.13 create_trigger.sgml
*** doc/src/sgml/ref/create_trigger.sgml	2001/05/27 09:59:28	1.13
--- doc/src/sgml/ref/create_trigger.sgml	2001/06/10 03:44:14
***************
*** 150,156 ****
      Only the relation owner may create a trigger on this relation.
     
     
!     As of the current release (v7.0), STATEMENT triggers are not implemented.
     
     
      Refer to DROP TRIGGER for information on how to 
--- 150,156 ----
      Only the relation owner may create a trigger on this relation.
     
     
!     As of the current release, STATEMENT triggers are not implemented.
     
     
      Refer to DROP TRIGGER for information on how to 
Index: doc/src/sgml/ref/psql-ref.sgml
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/ref/psql-ref.sgml,v
retrieving revision 1.55
diff -c -r1.55 psql-ref.sgml
*** doc/src/sgml/ref/psql-ref.sgml	2001/05/28 04:27:17	1.55
--- doc/src/sgml/ref/psql-ref.sgml	2001/06/10 03:44:16
***************
*** 1051,1057 ****
  
  	
  	
! 	As of psql version 7.0 it is no longer
  	necessary to save the command history, since that will be done
  	automatically on program termination. The history is
  	also loaded automatically every time psql
--- 1051,1057 ----
  
  	
  	
! 	In the current version, it is no longer
  	necessary to save the command history, since that will be done
  	automatically on program termination. The history is
  	also loaded automatically every time psql
***************
*** 1579,1585 ****
        
  
        
!       As of version 7.0, psql automatically issues a
        password prompt whenever the backend requests password authentication.
        Because this is currently based on a hack, the automatic
        recognition might mysteriously fail, hence this option to force a prompt.
--- 1579,1585 ----
        
  
        
!       In the current version, psql automatically issues a
        password prompt whenever the backend requests password authentication.
        Because this is currently based on a hack, the automatic
        recognition might mysteriously fail, hence this option to force a prompt.
Index: doc/src/sgml/ref/select.sgml
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/ref/select.sgml,v
retrieving revision 1.42
diff -c -r1.42 select.sgml
*** doc/src/sgml/ref/select.sgml	2001/05/30 04:32:30	1.42
--- doc/src/sgml/ref/select.sgml	2001/06/10 03:44:17
***************
*** 122,129 ****
  	table is scanned.  If ONLY is not specified, the table and all its
  	descendant tables (if any) are scanned.  * can be appended to the
  	table name to indicate that descendant tables are to be scanned,
! 	but as of Postgres 7.1 this is the default
! 	behavior.  (In releases before 7.1, ONLY was the default behavior.)
         
        
       
--- 122,129 ----
  	table is scanned.  If ONLY is not specified, the table and all its
  	descendant tables (if any) are scanned.  * can be appended to the
  	table name to indicate that descendant tables are to be scanned,
! 	but in the current version, this is the default behavior.
! 	(In releases before 7.1, ONLY was the default behavior.)
         
        
       
FAQ