Обсуждение: pgsql: Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.

Поиск
Список
Период
Сортировка

pgsql: Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.

От
Tom Lane
Дата:
Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.

Commit 874fe3aea changed the command tag returned for CREATE MATVIEW/CREATE
TABLE AS ... WITH NO DATA, but missed that there was code in spi.c that
expected the command tag to always be "SELECT".  Fortunately, the
consequence was only an Assert failure, so this oversight should have no
impact in production builds.

Since this code path was evidently un-exercised, add a regression test.

Per report from Shivam Saxena. Back-patch to 9.3, like the previous commit.

Michael Paquier

Report: <97218716-480B-4527-B5CD-D08D798A0C7B@dresources.com>

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/268d92e5336d25b296a5ccf8ccf803a2adb40251

Modified Files
--------------
src/backend/executor/spi.c            | 16 ++++++++++++----
src/test/regress/expected/matview.out | 25 +++++++++++++++++++++++++
src/test/regress/sql/matview.sql      | 14 ++++++++++++++
3 files changed, 51 insertions(+), 4 deletions(-)