Обсуждение: pgsql: Change InitToastSnapshot to a macro.

Change InitToastSnapshot to a macro.

tqual.h is included in some front-end compiles, and a static inline
breaks on buildfarm member castoroides.  Since the macro is never
referenced, it should dodge that problem, although this doesn't
seem like the cleanest way of hiding things from front-end compiles.

Report and review by Tom Lane; patch by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/81c766b3fd41c78c634d78ebae8d316808dfc630

Modified Files
--------------
src/backend/access/heap/tuptoaster.c |  2 +-
src/include/utils/tqual.h            | 11 ++++-------
2 files changed, 5 insertions(+), 8 deletions(-)

On 08/05/2016 12:04 PM, Robert Haas wrote:
> Change InitToastSnapshot to a macro.
>
> tqual.h is included in some front-end compiles, and a static inline
> breaks on buildfarm member castoroides.  Since the macro is never
> referenced, it should dodge that problem, although this doesn't
> seem like the cleanest way of hiding things from front-end compiles.
>
> Report and review by Tom Lane; patch by me.



Appears to have caused some buildfarm failures on the decoding tests.

cheers

andrew

Andrew Dunstan <andrew@dunslane.net> writes:
> Appears to have caused some buildfarm failures on the decoding tests.

Argh ... obvious typo, which I failed to see either.  Will fix.

            regards, tom lane