pgsql: Avoid possibly-unsafe use of Windows' FormatMessage() function.
pgsql: Avoid possibly-unsafe use of Windows' FormatMessage() function.
От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Avoid possibly-unsafe use of Windows' FormatMessage() function. Whenever this function is used with the FORMAT_MESSAGE_FROM_SYSTEM flag, it's good practice to include FORMAT_MESSAGE_IGNORE_INSERTS as well. Otherwise, if the message contains any %n insertion markers, the function will try to fetch argument strings to substitute --- which we are not passing, possibly leading to a crash. This is exactly analogous to the rule about not giving printf() a format string you're not in control of. Noted and patched by Christian Ullrich. Back-patch to all supported branches. Branch ------ REL9_3_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/11cc7bb8825efc74c9418f6e88d448cc253c47b0 Modified Files -------------- src/backend/libpq/auth.c | 4 +++- src/backend/port/win32/socket.c | 4 +++- src/interfaces/libpq/fe-auth.c | 4 +++- src/port/dirmod.c | 8 ++++++-- 4 files changed, 15 insertions(+), 5 deletions(-)