pgcrypto: Report errant decryption as "Wrong key or corrupt data".
This has been the predominant outcome. When the output of decrypting
with a wrong key coincidentally resembled an OpenPGP packet header,
pgcrypto could instead report "Corrupt data", "Not text data" or
"Unsupported compression algorithm". The distinct "Corrupt data"
message added no value. The latter two error messages misled when the
decrypted payload also exhibited fundamental integrity problems. Worse,
error message variance in other systems has enabled cryptologic attacks;
see RFC 4880 section "14. Security Considerations". Whether these
pgcrypto behaviors are likewise exploitable is unknown.
In passing, document that pgcrypto does not resist side-channel attacks.
Back-patch to 9.0 (all supported versions).
Security: CVE-2015-3167
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/fba1fb4efba51587cd0a9817af1f3e629caf157a
Modified Files
--------------
contrib/pgcrypto/expected/pgp-decrypt.out | 51 ++++++++++++++++
contrib/pgcrypto/expected/pgp-pubkey-decrypt.out | 4 +-
contrib/pgcrypto/mbuf.c | 2 +-
contrib/pgcrypto/pgp-decrypt.c | 70 ++++++++++++++++------
contrib/pgcrypto/pgp.h | 4 +-
contrib/pgcrypto/px.c | 3 -
contrib/pgcrypto/px.h | 2 -
contrib/pgcrypto/sql/pgp-decrypt.sql | 45 ++++++++++++++
doc/src/sgml/pgcrypto.sgml | 8 +++
9 files changed, 162 insertions(+), 27 deletions(-)