Обсуждение: pgsql: This routine was calling ecpg_alloc to allocate to memory but di
This routine was calling ecpg_alloc to allocate to memory but did not actually check the returned pointer allocated, potentially NULL which could be the result of a malloc call. Issue noted by Coverity, fixed by Michael Paquier <michael@otacoo.com> Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/5ee5bc387319b9ac33083bacebd3ab7046666328 Modified Files -------------- src/interfaces/ecpg/ecpglib/descriptor.c | 6 ++---- src/interfaces/ecpg/ecpglib/execute.c | 6 ++---- src/interfaces/ecpg/ecpglib/extern.h | 4 ++-- src/interfaces/ecpg/ecpglib/memory.c | 22 +++++++++++++++++++++- 4 files changed, 27 insertions(+), 11 deletions(-)
Re: pgsql: This routine was calling ecpg_alloc to allocate to memory but di
От
Michael Paquier
Дата:
On Thu, Feb 5, 2015 at 11:14 PM, Michael Meskes <meskes@postgresql.org> wrote: > This routine was calling ecpg_alloc to allocate to memory but did not > actually check the returned pointer allocated, potentially NULL which > could be the result of a malloc call. > > Issue noted by Coverity, fixed by Michael Paquier <michael@otacoo.com> Coming back to it, perhaps this meritates a backpatch? Even if that's unlikely to happen... -- Michael
On 23.07.2015 09:19, Michael Paquier wrote: > On Thu, Feb 5, 2015 at 11:14 PM, Michael Meskes <meskes@postgresql.org> wrote: >> This routine was calling ecpg_alloc to allocate to memory but did not >> actually check the returned pointer allocated, potentially NULL which >> could be the result of a malloc call. >> >> Issue noted by Coverity, fixed by Michael Paquier <michael@otacoo.com> > > Coming back to it, perhaps this meritates a backpatch? Even if that's > unlikely to happen... cherry-picked and pushed to all back branches. Sorry, the disadvantage of testing in master for a while, I simply forgot about this change. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
Re: pgsql: This routine was calling ecpg_alloc to allocate to memory but di
От
Michael Paquier
Дата:
On Wed, Aug 12, 2015 at 8:59 PM, Michael Meskes <meskes@postgresql.org> wrote: > On 23.07.2015 09:19, Michael Paquier wrote: >> On Thu, Feb 5, 2015 at 11:14 PM, Michael Meskes <meskes@postgresql.org> wrote: >>> This routine was calling ecpg_alloc to allocate to memory but did not >>> actually check the returned pointer allocated, potentially NULL which >>> could be the result of a malloc call. >>> >>> Issue noted by Coverity, fixed by Michael Paquier <michael@otacoo.com> >> >> Coming back to it, perhaps this meritates a backpatch? Even if that's >> unlikely to happen... > > cherry-picked and pushed to all back branches. > > Sorry, the disadvantage of testing in master for a while, I simply > forgot about this change. No pb. Thanks! I forgot myself... -- Michael