Clean up assorted issues in ALTER SYSTEM coding.
Fix unsafe use of a non-volatile variable in PG_TRY/PG_CATCH in
AlterSystemSetConfigFile(). While at it, clean up a bundle of other
infelicities and outright bugs, including corner-case-incorrect linked list
manipulation, a poorly designed and worse documented parse-and-validate
function (which even included some randomly chosen hard-wired substitutes
for the specified elevel in one code path ... wtf?), direct use of open()
instead of fd.c's facilities, inadequate checking of write()'s return
value, and generally poorly written commentary.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/bf007a27acd7b2fbaa4c8db293f156907cb01d27
Modified Files
--------------
src/backend/utils/misc/guc-file.l | 138 +++-----
src/backend/utils/misc/guc.c | 625 ++++++++++++++++++-------------------
2 files changed, 352 insertions(+), 411 deletions(-)