pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

Поиск
Список
Период
Сортировка
Искать

pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

От:
Robert Haas <rhaas@postgresql.org>
Дата:
Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

Andres Freund

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/17fa4c321ccf9693de406faffe6b235e949aa25f

Modified Files
--------------
src/backend/commands/vacuumlazy.c |   18 ++++++++++++++++++
1 file changed, 18 insertions(+)

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

От:
Andres Freund <andres@2ndquadrant.com>
Дата:
Hi,

On 2013-06-06 14:22:12 +0000, Robert Haas wrote:
> Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

This didn't make it to the release notes for 9.2.5. Since there have
been several people asking for it since, can we maybe add it
retroactively?

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

От:
Bruce Momjian <bruce@momjian.us>
Дата:
On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:
> Hi,
> 
> On 2013-06-06 14:22:12 +0000, Robert Haas wrote:
> > Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.
> 
> This didn't make it to the release notes for 9.2.5. Since there have
> been several people asking for it since, can we maybe add it
> retroactively?

OK, what text would I use?  This?

    * Prevent unitialized heap pages from causing standby replay
      failures

-- 
  Bruce Momjian          http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

От:
Andres Freund <andres@2ndquadrant.com>
Дата:
On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote:
> On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:
> > Hi,
> > 
> > On 2013-06-06 14:22:12 +0000, Robert Haas wrote:
> > > Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.
> > 
> > This didn't make it to the release notes for 9.2.5. Since there have
> > been several people asking for it since, can we maybe add it
> > retroactively?
> 
> OK, what text would I use?  This?
> 
>     * Prevent unitialized heap pages from causing standby replay
>       failures

Maybe:

* Prevent errors in WAL replay due to references to unitilizated empty
  pages in vacuum.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

От:
Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
Дата:
On 11/18/2013 10:40 PM, Andres Freund wrote:
> On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote:
>> On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:
>>> Hi,
>>>
>>> On 2013-06-06 14:22:12 +0000, Robert Haas wrote:
>>>> Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.
>>>
>>> This didn't make it to the release notes for 9.2.5. Since there have
>>> been several people asking for it since, can we maybe add it
>>> retroactively?
>>
>> OK, what text would I use?  This?
>>
>>     * Prevent unitialized heap pages from causing standby replay
>>       failures
> 
> Maybe:
> 
> * Prevent errors in WAL replay due to references to unitilizated empty
>   pages in vacuum.

s/unitilizated/uninitialized I guess - also not sure the "in vacuum"
makes the actual issue very clear.



Stefan

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

От:
Bruce Momjian <bruce@momjian.us>
Дата:
On Fri, Nov 22, 2013 at 08:04:07PM +0100, Stefan Kaltenbrunner wrote:
> On 11/18/2013 10:40 PM, Andres Freund wrote:
> > On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote:
> >> On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:
> >>> Hi,
> >>>
> >>> On 2013-06-06 14:22:12 +0000, Robert Haas wrote:
> >>>> Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.
> >>>
> >>> This didn't make it to the release notes for 9.2.5. Since there have
> >>> been several people asking for it since, can we maybe add it
> >>> retroactively?
> >>
> >> OK, what text would I use?  This?
> >>
> >>     * Prevent unitialized heap pages from causing standby replay
> >>       failures
> > 
> > Maybe:
> > 
> > * Prevent errors in WAL replay due to references to unitilizated empty
> >   pages in vacuum.
> 
> s/unitilizated/uninitialized I guess - also not sure the "in vacuum"
> makes the actual issue very clear.

Applied and backpatched through 9.2.  Thanks.

-- 
  Bruce Momjian          http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

FAQ