Обсуждение: pgsql: Add pg_xlogdump contrib program
Add pg_xlogdump contrib program This program relies on rm_desc backend routines and the xlogreader infrastructure to emit human-readable rendering of WAL records. Author: Andres Freund, with many reworks by Álvaro Reviewed (in a much earlier version) by Peter Eisentraut Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/639ed4e84b7493594860f56b78b25fd113e78fd7 Modified Files -------------- contrib/pg_xlogdump/Makefile | 32 ++ contrib/pg_xlogdump/compat.c | 94 +++++ contrib/pg_xlogdump/pg_xlogdump.c | 711 +++++++++++++++++++++++++++++++++++++ contrib/pg_xlogdump/rmgrdesc.c | 36 ++ contrib/pg_xlogdump/rmgrdesc.h | 21 ++ doc/src/sgml/contrib.sgml | 1 + doc/src/sgml/filelist.sgml | 1 + doc/src/sgml/pg_xlogdump.sgml | 205 +++++++++++ doc/src/sgml/ref/pg_isready.sgml | 2 +- src/include/utils/palloc.h | 4 +- 10 files changed, 1104 insertions(+), 3 deletions(-)
On 22 February 2013 19:58, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > Add pg_xlogdump contrib program > > This program relies on rm_desc backend routines and the xlogreader > infrastructure to emit human-readable rendering of WAL records. > > Author: Andres Freund, with many reworks by Álvaro > Reviewed (in a much earlier version) by Peter Eisentraut > > Branch > ------ > master > > Details > ------- > http://git.postgresql.org/pg/commitdiff/639ed4e84b7493594860f56b78b25fd113e78fd7 > > Modified Files > -------------- > contrib/pg_xlogdump/Makefile | 32 ++ > contrib/pg_xlogdump/compat.c | 94 +++++ > contrib/pg_xlogdump/pg_xlogdump.c | 711 +++++++++++++++++++++++++++++++++++++ > contrib/pg_xlogdump/rmgrdesc.c | 36 ++ > contrib/pg_xlogdump/rmgrdesc.h | 21 ++ > doc/src/sgml/contrib.sgml | 1 + > doc/src/sgml/filelist.sgml | 1 + > doc/src/sgml/pg_xlogdump.sgml | 205 +++++++++++ > doc/src/sgml/ref/pg_isready.sgml | 2 +- > src/include/utils/palloc.h | 4 +- > 10 files changed, 1104 insertions(+), 3 deletions(-) Hmm... did you try building the docs before committing this? I'm getting an error. make -C sgml html make[1]: Entering directory `/home/thom/Development/postgresql/doc/src/sgml' openjade -wall -wno-unused-param -wno-empty -wfully-tagged -D . -D . -c /usr/share/sgml/docbook/stylesheet/dsssl/modular/catalog -d stylesheet.dsl -t sgml -i output-html -V html-index postgres.sgml openjade:pg_xlogdump.sgml:6:16:E: character "_" is not allowed in the value of attribute "ID" openjade:pg_xlogdump.sgml:18:20:E: character "_" is not allowed in the value of attribute "ZONE" openjade:pg_xlogdump.sgml:203:10:E: end tag for element "RFSECT1" which is not open openjade:pg_xlogdump.sgml:205:10:E: end tag for "REFSECT1" omitted, but OMITTAG NO was specified openjade:pg_xlogdump.sgml:197:1: start tag was here make[1]: *** [HTML.index] Error 1 make[1]: *** Deleting file `HTML.index' make[1]: Leaving directory `/home/thom/Development/postgresql/doc/src/sgml' make: *** [html] Error 2 -- Thom
On 22 February 2013 19:58, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > Add pg_xlogdump contrib program I feel slightly silly reporting this, but you probably should have updated the copyright years to 2013 before committing. -- Regards, Peter Geoghegan
On 22 February 2013 20:09, Peter Geoghegan <peter.geoghegan86@gmail.com> wrote: > On 22 February 2013 19:58, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: >> Add pg_xlogdump contrib program > > I feel slightly silly reporting this, but you probably should have > updated the copyright years to 2013 before committing. And while you're there: "<command>pg_xlogdump</command> display the write-ahead log" s/display/displays/ -- Thom
Thom Brown escribió: > On 22 February 2013 20:09, Peter Geoghegan <peter.geoghegan86@gmail.com> wrote: > > On 22 February 2013 19:58, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > >> Add pg_xlogdump contrib program > > > > I feel slightly silly reporting this, but you probably should have > > updated the copyright years to 2013 before committing. > > And while you're there: > > "<command>pg_xlogdump</command> display the write-ahead log" > > s/display/displays/ A large number of mistakes! Thanks for spotting quickly. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On Sat, Feb 23, 2013 at 4:58 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > Add pg_xlogdump contrib program I got an error on make after make clean. Should we remove rmgrdesc.c from EXTRA_CLEAN and target? [pg_xlogdump(master)]$ make clean rm -f pg_xlogdump rm -f pg_xlogdump.o compat.o xlogreader.o rmgrdesc.o clogdesc.o dbasedesc.o gindesc.o gistdesc.o hashdesc.o heapdesc.o mxactdesc.o nbtdesc.o relmapdesc.o seqdesc.o smgrdesc.o spgdesc.o standbydesc.o tblspcdesc.o xactdesc.o xlogdesc.o rm -rf clogdesc.c dbasedesc.c gindesc.c gistdesc.c hashdesc.c heapdesc.c mxactdesc.c nbtdesc.c relmapdesc.c seqdesc.c smgrdesc.c spgdesc.c standbydesc.c tblspcdesc.c xactdesc.c xlogdesc.c xlogreader.c rmgrdesc.c [pg_xlogdump(master)]$ make gcc -O0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -g -DFRONTEND -I. -I. -I../../src/include -c -o pg_xlogdump.o pg_xlogdump.c gcc -O0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -g -DFRONTEND -I. -I. -I../../src/include -c -o compat.o compat.c rm -f xlogreader.c && ln -s ../../src/backend/access/transam/xlogreader.c . gcc -O0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -g -DFRONTEND -I. -I. -I../../src/include -c -o xlogreader.o xlogreader.c make: *** No rule to make target `../../src/backend/access/transam/rmgrdesc.c', needed by `rmgrdesc.c'. Stop. [pg_xlogdump(master)]$ -- Shigeru HANADA