Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.) When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk. Better to throw a suitable error when the
DROP is attempted.
Also add a similar check in DROP INDEX.
Back-patch to all supported branches.
Branch
------
REL9_0_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/8e4b1473126cc72fa9bcc5b079055c71bc267656
Modified Files
--------------
src/backend/catalog/heap.c | 10 +++-------
src/backend/catalog/index.c | 6 ++++++
src/interfaces/ecpg/test/expected/sql-fetch.stderr | 6 +++---
3 files changed, 12 insertions(+), 10 deletions(-)