pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared

Поиск
Список
Период
Сортировка
Искать

pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared

От:
momjian@postgresql.org (Bruce Momjian)
Дата:
Log Message:
-----------
Add PGDLLIMPORT for binary_upgrade global variables so shared object
libraries can access them.

Modified Files:
--------------
    pgsql/src/backend/catalog:
        pg_type.c (r1.128 -> r1.129)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_type.c?r1=1.128&r2=1.129)
        toasting.c (r1.23 -> r1.24)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/toasting.c?r1=1.23&r2=1.24)
    pgsql/src/backend/commands:
        typecmds.c (r1.142 -> r1.143)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/typecmds.c?r1=1.142&r2=1.143)

Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared

От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
momjian@postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> Add PGDLLIMPORT for binary_upgrade global variables so shared object
> libraries can access them.

This change is useless, and contrary to our coding standards elsewhere.
You need PGDLLIMPORT on the externs seen by the loadable module.  We
don't put it on the actual variable definitions.

			regards, tom lane

Re: pgsql: Add PGDLLIMPORT for binary_upgrade global variables so shared

От:
Bruce Momjian <bruce@momjian.us>
Дата:
Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Add PGDLLIMPORT for binary_upgrade global variables so shared object
> > libraries can access them.
> 
> This change is useless, and contrary to our coding standards elsewhere.
> You need PGDLLIMPORT on the externs seen by the loadable module.  We
> don't put it on the actual variable definitions.

Thanks, I will make the necessary adjustments.

-- 
  Bruce Momjian          http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
FAQ