pgsql: Use special gcc -W flags only if we are using gcc, not if we are
pgsql: Use special gcc -W flags only if we are using gcc, not if we are
От:
momjian@postgresql.org (Bruce Momjian)
Дата:
Log Message:
-----------
Use special gcc -W flags only if we are using gcc, not if we are using
the Intel compiler.
Jeremy Drake
Modified Files:
--------------
pgsql:
configure (r1.487 -> r1.488)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.diff?r1=1.487&r2=1.488)
configure.in (r1.457 -> r1.458)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.in.diff?r1=1.457&r2=1.458)
Re: pgsql: Use special gcc -W flags only if we are using gcc, not if we are
От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
momjian@postgresql.org (Bruce Momjian) writes: > Use special gcc -W flags only if we are using gcc, not if we are using > the Intel compiler. I'm not entirely thrilled with this patch, because it disables not only the -W options but also -fno-strict-aliasing. Are you sure the latter is not needed for ICC? regards, tom lane
Re: pgsql: Use special gcc -W flags only if we are using
От:
Bruce Momjian <pgman@candle.pha.pa.us>
Дата:
Tom Lane wrote: > momjian@postgresql.org (Bruce Momjian) writes: > > Use special gcc -W flags only if we are using gcc, not if we are using > > the Intel compiler. > > I'm not entirely thrilled with this patch, because it disables not only > the -W options but also -fno-strict-aliasing. Are you sure the latter > is not needed for ICC? Peter asked for specific problems with the warnings, and the submitter produced results. I see no mention of -fno-strict-aliasing: http://archives.postgresql.org/pgsql-patches/2006-04/msg00002.php However, the -f flag is outside the block he modified: # Disable strict-aliasing rules; needed for gcc 3.3+ PGAC_PROG_CC_CFLAGS_OPT([-fno-strict-aliasing]) That flag is still used for both gcc and the intel compiler, and because he tested the patch, I assume it works for both too. -- Bruce Momjian http://candle.pha.pa.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Re: pgsql: Use special gcc -W flags only if we are using gcc, not if we are
От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Bruce Momjian writes: > Tom Lane wrote: >> I'm not entirely thrilled with this patch, because it disables not only >> the -W options but also -fno-strict-aliasing. Are you sure the latter >> is not needed for ICC? > However, the -f flag is outside the block he modified: D'oh, I misread where the "fi" was placed. I can only plead a momentary attack of the stupids. Never mind ... regards, tom lane