Обсуждение: pgsql-server: OK, another try at Darwin threads.

Log Message:
-----------
OK, another try at Darwin threads.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
    pgsql-server/src/template:
        darwin (r1.4.2.2 -> r1.4.2.3)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/template/darwin.diff?r1=1.4.2.2&r2=1.4.2.3)

momjian@svr1.postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> OK, another try at Darwin threads.

> Tags:
> ----
> REL7_4_STABLE

Seems to me that unproven fixes do not belong in stable branches.

            regards, tom lane

Tom Lane wrote:
> momjian@svr1.postgresql.org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > OK, another try at Darwin threads.
>
> > Tags:
> > ----
> > REL7_4_STABLE
>
> Seems to me that unproven fixes do not belong in stable branches.

The fix was tested by several people on several versions of OSX, and it
is only enabled when compiling with thread-safety.  I don't see a
problem.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> momjian@svr1.postgresql.org (Bruce Momjian) writes:
>>> OK, another try at Darwin threads.
>>
>> Seems to me that unproven fixes do not belong in stable branches.

> The fix was tested by several people on several versions of OSX, and it
> is only enabled when compiling with thread-safety.  I don't see a
> problem.

I found that out later on in another thread.  The problem is with the
commit message, which makes it sound like this is an untested "maybe
this will work" patch ...

            regards, tom lane

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> momjian@svr1.postgresql.org (Bruce Momjian) writes:
> >>> OK, another try at Darwin threads.
> >>
> >> Seems to me that unproven fixes do not belong in stable branches.
>
> > The fix was tested by several people on several versions of OSX, and it
> > is only enabled when compiling with thread-safety.  I don't see a
> > problem.
>
> I found that out later on in another thread.  The problem is with the
> commit message, which makes it sound like this is an untested "maybe
> this will work" patch ...

Yes, the commit message was unclear.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073