pgsql (configure.in configure)
pgsql (configure.in configure)
От:
Tom Lane <tgl>
Дата:
Date: Wednesday, June 28, 2000 @ 00:58:37
Author: tgl
Update of /home/projects/pgsql/cvsroot/pgsql
from hub.org:/home/projects/pgsql/tmp/cvs-serv75248
Modified Files:
configure.in configure
----------------------------- Log Message -----------------------------
Call me silly, but I think it would be a good idea if initdb and other
scripts are executable after being installed. Latest changes got the
permissions wrong (non executable).
Re: pgsql (configure.in configure)
От:
Peter Eisentraut <peter_e@gmx.net>
Дата:
Tom Lane writes: > Call me silly, but I think it would be a good idea if initdb and other > scripts are executable after being installed. Latest changes got the > permissions wrong (non executable). What's kind of silly is that install should default to mode 755 and INSTALL_SCRIPT should default to `install -c'. Is that not the case here? -- Peter Eisentraut Sernanders väg 10:115 peter_e@gmx.net 75262 Uppsala http://yi.org/peter-e/ Sweden
Re: pgsql (configure.in configure)
От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Peter Eisentraut writes: > Tom Lane writes: >> Call me silly, but I think it would be a good idea if initdb and other >> scripts are executable after being installed. Latest changes got the >> permissions wrong (non executable). > What's kind of silly is that install should default to mode 755 and > INSTALL_SCRIPT should default to `install -c'. Is that not the case here? Why should install default to mode 755? On my system install -c just does a cp; it doesn't change permissions unless you explicitly specify a -m flag, which the makefiles were not doing. This'd be OK if the scripts were mode 755 in the source tree, but they ain't (and I think it's a bad idea to depend on the permissions in the source tree anyway). Before your latest changes, the makefiles explicitly specified a -m setting for every invocation of install. You can argue about whether the permission values we used were reasonable or not, but at least we got predictable results. I think we should keep that behavior. regards, tom lane