Обсуждение: BUG #14315: pg_dump --no-tablespaces doesn't do it's job when --create specified

Поиск
Список
Период
Сортировка

BUG #14315: pg_dump --no-tablespaces doesn't do it's job when --create specified

От
abcz2.uprola@gmail.com
Дата:
VGhlIGZvbGxvd2luZyBidWcgaGFzIGJlZW4gbG9nZ2VkIG9uIHRoZSB3ZWJz
aXRlOgoKQnVnIHJlZmVyZW5jZTogICAgICAxNDMxNQpMb2dnZWQgYnk6ICAg
ICAgICAgIERhbnlsbyBIbHluc2t5aQpFbWFpbCBhZGRyZXNzOiAgICAgIGFi
Y3oyLnVwcm9sYUBnbWFpbC5jb20KUG9zdGdyZVNRTCB2ZXJzaW9uOiA5LjUu
NApPcGVyYXRpbmcgc3lzdGVtOiAgIEFtYXpvbiBMaW51eApEZXNjcmlwdGlv
bjogICAgICAgIAoKSSBoYXZlIGEgZGF0YWJhc2UgaW4gY3VzdG9tIHRhYmxl
c3BhY2UgYW5kIEkgd2FudCB0byBwZ19kdW1wL3BnX3Jlc3RvcmUgaXQKaW4g
YW5vdGhlciBwbGFjZSB3aXRob3V0IHRhYmxlc3BhY2UuDQoNCkJ1dCBJIG5v
dGljZWQgdGhhdCAtLW5vLXRhYmxlc3BhY2VzIGRvZXNuJ3QgY2hhbmdlIC0t
Y3JlYXRlIG9wdGlvbiB0byBub3QKaW5jbHVkZSB0YWJsZXNwYWNlczoNCg0K
ICQgcGdfZHVtcCAtQyAtLXNjaGVtYS1vbmx5IC1VIHBvc3RncmVzIC1oIHRl
c3QgLS1uby10YWJsZXNwYWNlcyAtZAp3cF9hbmFseXRpY3MgfCBncmVwICJD
UkVBVEUgREFUQUJBU0UiDQpDUkVBVEUgREFUQUJBU0Ugd3BfYW5hbHl0aWNz
IFdJVEggVEVNUExBVEUgPSB0ZW1wbGF0ZTAgRU5DT0RJTkcgPSAnVVRGOCcK
TENfQ09MTEFURSA9ICdlbl9VUy5VVEYtOCcgTENfQ1RZUEUgPSAnZW5fVVMu
VVRGLTgnIFRBQkxFU1BBQ0UgPQp3cF90YmxzcGM7DQoNCkkgdGhpbmsgdGhh
dCBpdCBpcyBhIGJ1Zy4gSWYgSSBzcGVjaWZ5IC0tY3JlYXRlIGFuZCAtLW5v
LXRhYmxlc3BhY2VzCnRvZ2V0aGVyIHRoYW4gIlRBQkxFU1BBQ0UgPSB3cF90
YmxzcGMiIHNob3VsZCBiZSBhYnNlbnQgaW4gcmVzdWx0aW5nCmNvbW1hbmQu
Cgo=

Re: BUG #14315: pg_dump --no-tablespaces doesn't do it's job when --create specified

От
Tom Lane
Дата:
abcz2.uprola@gmail.com writes:
> But I noticed that --no-tablespaces doesn't change --create option to not
> include tablespaces:

>  $ pg_dump -C --schema-only -U postgres -h test --no-tablespaces -d
> wp_analytics | grep "CREATE DATABASE"
> CREATE DATABASE wp_analytics WITH TEMPLATE = template0 ENCODING = 'UTF8'
> LC_COLLATE = 'en_US.UTF-8' LC_CTYPE = 'en_US.UTF-8' TABLESPACE =
> wp_tblspc;

> I think that it is a bug.

Yeah, I think you're right, especially since the corresponding code in
pg_dumpall does suppress the TABLESPACE clause with --no-tablespaces.

            regards, tom lane