Обсуждение: BUG #6671: Killed restore command causes postmaster to exit

The following bug has been logged on the website:

Bug reference:      6671
Logged by:          Ed Muller
Email address:      edward@heroku.com
PostgreSQL version: 9.0.7
Operating system:   Linux (Ubuntu 10.04)
Description:=20=20=20=20=20=20=20=20

We have this thing where we kill the restore command sometimes, to ensure
it's not stuck.=20

This has rarely led to postmaster dying afterwards instead of retrying.

Here are some related logs...

[CRIMSON] LOG:  restored log file "00000006000031B500000099" from archive

[CRIMSON] FATAL:  could not restore file "00000006000031B50000009A" from
archive: return code 36608

[CRIMSON] LOG:  startup process (PID 854) exited with exit code 1

[CRIMSON] LOG:  terminating any other active server processes

edward@heroku.com writes:
> We have this thing where we kill the restore command sometimes, to ensure
> it's not stuck.

Um, what makes you think that's a good idea?

> This has rarely led to postmaster dying afterwards instead of retrying.

"Rarely"?  As I read the code, it will happen every single time.
Failure of the restore process is a failure, we do not retry.
(The general theory is that if you think you need retries, you
should code the restore_command to handle that.)

            regards, tom lane