Обсуждение: Beta 3

Поиск
Список
Период
Сортировка

Beta 3

От
Kieran McCusker
Дата:
<font face="Helvetica, Arial, sans-serif">Hi<br /><br /> Firstly, congratulations on beta 3. An issue I had with the
timeit took to for the object browser to refresh has gone away (I was waiting for the logging fix I raised to
investigatemyself), and the issue with tabs in the query window has also been fixed. The performance of the graphical
querybuilder is now fine as well.<br /><br /> Could I raise a few small points?<br /><br /> 1. Query window forgets
undohistory when it loses focus.<br /> Under Vista if you switch to another window and back to a query window the the
undohistory is forgotten, the find and replace and cut menu items are disabled (although still reachable with
ctrl-f).<br/><br /> 2. Graphical query builder<br /> The message boxes "No SQL query was generated" and "The generated
SQLquery has changed. Do you want to update it?" become rather trying after a while (at least to me). Could they not
appearas status bar messages?<br /> The first one would be fine as is, the second raises another slight issue. The
statusbar could say something like  </font><font face="Helvetica, Arial, sans-serif">"The generated SQL query has
changed."with undo reverting to the last sql, but what actually happens is that their is a clear window in the history
aswell, so you need two undos to get back to the previous SQL - This is a little confusing could they be grouped as a
singleundo?<br /><br /> 3. New Server Registration<br /> While DB restriction is fixed in server properties, it is not
actuallyused or stored in </font><font face="Helvetica, Arial, sans-serif">New Server Registration i.e. entering a DB
restrictionhere has no effect.<br /><br /> 4. The Links in pgAdmin III help do not all work<br /> I noticed this
lookingat Connect to Server where at least the pg_namespace link does not work<br /><br /> Anyway many thanks again for
agreat piece of software!<br /><br /> Kieran<br /><br /></font><font face="Helvetica, Arial, sans-serif"><br /><br
/><br/><br /></font> 

Re: Beta 3

От
Dave Page
Дата:
On Fri, May 8, 2009 at 10:22 AM, Kieran McCusker
<kieran.mccusker@kwest.info> wrote:
> Could I raise a few small points?

Sure.

> 1. Query window forgets undo history when it loses focus.
> Under Vista if you switch to another window and back to a query window the
> the undo history is forgotten, the find and replace and cut menu items are
> disabled (although still reachable with ctrl-f).

This sounds like it might be related to a copy/paste issue that Ashesh
has sent me a patch for. Ashesh, can you check that please?

> 2. Graphical query builder
> The message boxes "No SQL query was generated" and "The generated SQL query
> has changed. Do you want to update it?" become rather trying after a while
> (at least to me). Could they not appear as status bar messages?
> The first one would be fine as is, the second raises another slight issue.
> The status bar could say something like  "The generated SQL query has
> changed." with undo reverting to the last sql, but what actually happens is
> that their is a clear window in the history as well, so you need two undos
> to get back to the previous SQL - This is a little confusing could they be
> grouped as a single undo?

If I'm honest, I prefer the positive alert for the second message. I
could be swayed on the first though.

> 3. New Server Registration
> While DB restriction is fixed in server properties, it is not actually used
> or stored in New Server Registration i.e. entering a DB restriction here has
> no effect.

Ashesh, can you investigate that as well please?

> 4. The Links in pgAdmin III help do not all work
> I noticed this looking at Connect to Server where at least the pg_namespace
> link does not work

That's from when the PG docs used to be in the same HTML Help file.
I've changed those links to point to the PostgreSQL website.
Unfortunately I don't see any way to point them to the actual help
source without implementing our own version of the help browser.

> Anyway many thanks again for a great piece of software!

You're welcome.

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com


Re: Beta 3

От
Ashesh Vashi
Дата:
Hi Dave,

Dave Page wrote:
On Fri, May 8, 2009 at 10:22 AM, Kieran McCusker
<kieran.mccusker@kwest.info> wrote:
Could I raise a few small points?
Sure
1. Query window forgets undo history when it loses focus.
Under Vista if you switch to another window and back to a query window the
the undo history is forgotten, the find and replace and cut menu items are
disabled (although still reachable with ctrl-f).
This sounds like it might be related to a copy/paste issue that Ashesh
has sent me a patch for. Ashesh, can you check that please?
I think - the patch, I sent, should resolve this issue.
3. New Server Registration
While DB restriction is fixed in server properties, it is not actually used
or stored in New Server Registration i.e. entering a DB restriction here has
no effect.
Ashesh, can you investigate that as well please?
Kieran Mccusker is right, we missed to add a piece of code for storing DbRestriction,
while registering the new server.

I will send the patch soon.

--
Thanks & Regards,
Ashesh Vashi

EnterpriseDB INDIA: http://www.enterprisedb.com