Обсуждение: [pgAdmin4][Patch]: Node issues under catalogs
Вложения
HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'
},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'
}]Please find attached patch and review.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'}]Please find attached patch and review.Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.Please share a separate patch for above fixes.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'}]Please find attached patch and review.Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
On Thu, May 26, 2016 at 8:58 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.Please share a separate patch for above fixes.OK
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'}]Please find attached patch and review.Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Вложения
On Thu, May 26, 2016 at 9:28 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:On Thu, May 26, 2016 at 8:58 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.Please share a separate patch for above fixes.OKPFA patch for above two issues.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'}]Please find attached patch and review.Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'This is wrong - you should not put the group-id as i18n string.It should be a simple string. i.e. group: 'security'},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'Same as above.}]Please find attached patch and review.I also found - we're not consistent about showing ACL on all the node.For some node, we're not showing ACLs in properties mode.Please send patch with above fixes.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Вложения
HiPFA patch with following fixes:1. Introduced a new function 'is_security_group_under_catalog' which return false if node of type: group is undercatalog otherwise true.2. In security group, group-id is simple string.3. Fixed indentation in schema.js.4. Also set parent_type of sequence node to catalogs which i missed in previous patch.Please review the patch.On Thu, May 26, 2016 at 8:57 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:HiFollowing are the issues fixed in this patch:1. Nodes not expanding under catalogsIssue: Check for setting schema was missing. schema should set only if node is in create mode.2. Error fetching node's properties.Issue: Node attribute parent_type is not set to catalogs.3. Don't show create rule option in table create menu if it is under catalog.4. Security tab of node should be hidden under catalogs.Every node with controls privilege and security labels must be under type: groupto keep them hide when node is listed under catalogs.This code is implemented in backform.pgadmin.jsFor Example:schema:[{id: 'security', label: '{{ _("Security") }}',type: 'group'},{id: 'acl', label: '{{ _('Privileges') }}', group: '{{ _('security') }}'This is wrong - you should not put the group-id as i18n string.It should be a simple string. i.e. group: 'security'},{id: 'seclabels', label: '{{ _('Security Labels') }}',model: SecurityModel, type: 'collection',group: '{{ _('security') }}'Same as above.}]Please find attached patch and review.I also found - we're not consistent about showing ACL on all the node.For some node, we're not showing ACLs in properties mode.Please send patch with above fixes.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Thanks,Surinder Kumar
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers