Обсуждение: PATCH: Fixed typo in Server node

Поиск
Список
Период
Сортировка

PATCH: Fixed typo in Server node

От
Murtuza Zabuawala
Дата:
Hi,

Looks like below given commit has left a typo in the code, I’m getting error while updating any Server node,

Commit:
0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page         2016-05-05 16:42:16 +0100 377)             node=self.blueprint.generate_browser_node(

Error:
    return method(*args, **kwargs)
  File "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py", line 385, in update
    server_type='pg'  # default server type
TypeError: make_json_response() got an unexpected keyword argument ‘node'



PFA patch to fix the issue.



Regards,
Murtuza
Вложения

Re: PATCH: Fixed typo in Server node

От
Dave Page
Дата:
Thanks - applied.

On Fri, May 6, 2016 at 11:14 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> Looks like below given commit has left a typo in the code, I’m getting error
> while updating any Server node,
>
> Commit:
> 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page
> 2016-05-05 16:42:16 +0100 377)
> node=self.blueprint.generate_browser_node(
>
> Error:
>     return method(*args, **kwargs)
>   File
> "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
> line 385, in update
>     server_type='pg'  # default server type
> TypeError: make_json_response() got an unexpected keyword argument ‘node'
>
>
>
> PFA patch to fix the issue.
>
>
>
> Regards,
> Murtuza
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company