Обсуждение: Subnode grid row close issue [pgAdmin4]
Hi,
PFA patch for Subnode grid row close issue.2] Close any existing row if we edit new row.
Вложения
Hi
--
On Thu, Mar 17, 2016 at 11:14 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
1] Close any existing row while adding new row.Issue fixed:Hi,PFA patch for Subnode grid row close issue.
2] Close any existing row if we edit new row.
This doesn't appear to make any difference to me. I've confirmed the patch is applied, restarted the app, emptied my cache and reloaded, and tested with composite types on the Create Type dialogue. I still see multiple row forms when I hit the ADD button if one is already open.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi,
Here is updated patch.On Thu, Mar 17, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Thu, Mar 17, 2016 at 11:14 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:1] Close any existing row while adding new row.Issue fixed:Hi,PFA patch for Subnode grid row close issue.
2] Close any existing row if we edit new row.This doesn't appear to make any difference to me. I've confirmed the patch is applied, restarted the app, emptied my cache and reloaded, and tested with composite types on the Create Type dialogue. I still see multiple row forms when I hit the ADD button if one is already open.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks - applied.
On Thu, Mar 17, 2016 at 3:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
In initial patch I fixed this issue in only Subnode control while Type node uses unique collection control (which is special case of subnode control). Now I have fixed in both control.Hi,Here is updated patch.On Thu, Mar 17, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Thu, Mar 17, 2016 at 11:14 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:1] Close any existing row while adding new row.Issue fixed:Hi,PFA patch for Subnode grid row close issue.
2] Close any existing row if we edit new row.This doesn't appear to make any difference to me. I've confirmed the patch is applied, restarted the app, emptied my cache and reloaded, and tested with composite types on the Create Type dialogue. I still see multiple row forms when I hit the ADD button if one is already open.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company