Обсуждение: patch: fixing dublicates foreign-tables

Поиск
Список
Период
Сортировка

patch: fixing dublicates foreign-tables

От
Andrej Antonov
Дата:
fixing dublicates foreign-tables (see attachment file).

this email -- it is just copy of pull-request
https://github.com/postgres/pgadmin3/pull/11 .

thanks in advance.

--
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»
Вложения

Re: patch: fixing dublicates foreign-tables

От
Dave Page
Дата:
Akshay, can you review this please?

2015-12-07 19:47 GMT+05:30 Andrej Antonov <antonov@imp-m.ru>:
> fixing dublicates foreign-tables (see attachment file).
>
> this email -- it is just copy of pull-request
> https://github.com/postgres/pgadmin3/pull/11 .
>
> thanks in advance.
>
> --
> Андрей Антонов,
> инженер-программист отдела информационных технологий и программирования,
> компания «Импульс М»
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: patch: fixing dublicates foreign-tables

От
Akshay Joshi
Дата:


On Tue, Dec 8, 2015 at 11:09 AM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, can you review this please?
 
   Sure, Dave. 

2015-12-07 19:47 GMT+05:30 Andrej Antonov <antonov@imp-m.ru>:
> fixing dublicates foreign-tables (see attachment file).
>
> this email -- it is just copy of pull-request
> https://github.com/postgres/pgadmin3/pull/11 .
>
> thanks in advance.
>
> --
> Андрей Антонов,
> инженер-программист отдела информационных технологий и программирования,
> компания «Импульс М»
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: patch: fixing dublicates foreign-tables

От
Akshay Joshi
Дата:
Hi Andrej 

Can you please share the reproduction step of the issue that you have fixed.  

On Tue, Dec 8, 2015 at 11:15 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Tue, Dec 8, 2015 at 11:09 AM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, can you review this please?
 
   Sure, Dave. 

2015-12-07 19:47 GMT+05:30 Andrej Antonov <antonov@imp-m.ru>:
> fixing dublicates foreign-tables (see attachment file).
>
> this email -- it is just copy of pull-request
> https://github.com/postgres/pgadmin3/pull/11 .
>
> thanks in advance.
>
> --
> Андрей Антонов,
> инженер-программист отдела информационных технологий и программирования,
> компания «Импульс М»
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: patch: fixing dublicates foreign-tables

От
Andrej Antonov
Дата:
hello, Akshay!

screenshot:

"Screenshot from 2015-12-08 13-43-54 with-labels.png" (as attachment
file).

script to reproduce:



         CREATE FOREIGN DATA WRAPPER postgresql
           VALIDATOR postgresql_fdw_validator;

         CREATE SERVER film_server FOREIGN DATA WRAPPER postgresql
OPTIONS (host 'foo', dbname 'foodb', port '5432');

         CREATE FOREIGN TABLE films1 (
             code        char(5) NOT NULL,
             title       varchar(40) NOT NULL,
             did         integer NOT NULL,
             date_prod   date,
             kind        varchar(10),
             len         interval hour to minute
         )
         SERVER film_server;

         CREATE FOREIGN TABLE films2 (
             code        char(5) NOT NULL,
             title       varchar(40) NOT NULL,
             did         integer NOT NULL,
             date_prod   date,
             kind        varchar(10),
             len         interval hour to minute
         )
         SERVER film_server;

         COMMENT ON FOREIGN TABLE films1 IS 'description A';
         COMMENT ON FOREIGN TABLE films2 IS 'description B';

         COMMENT ON COLUMN films1.code IS 'descr code A';
         COMMENT ON COLUMN films1.title IS 'descr title A';
         COMMENT ON COLUMN films1.did IS 'descr did A';
         COMMENT ON COLUMN films2.code IS 'descr code B';
         COMMENT ON COLUMN films2.title IS 'descr title B';
         COMMENT ON COLUMN films2.did IS 'descr did B';



Akshay Joshi писал 2015-12-08 13:21:
> Hi Andrej
>
> Can you please share the reproduction step of the issue that you have
> fixed.
>
> On Tue, Dec 8, 2015 at 11:15 AM, Akshay Joshi
> <akshay.joshi@enterprisedb.com> wrote:
>
>> On Tue, Dec 8, 2015 at 11:09 AM, Dave Page <dpage@pgadmin.org>
>> wrote:
>>
>>> Akshay, can you review this please?
>>
>> Sure, Dave.
>>
>>> 2015-12-07 19:47 GMT+05:30 Andrej Antonov <antonov@imp-m.ru>:
>>>> fixing dublicates foreign-tables (see attachment file).
>>>>
>>>> this email -- it is just copy of pull-request
>>>> https://github.com/postgres/pgadmin3/pull/11 [1] .
>>>>
>>>> thanks in advance.
>>>>
>>>> --
>>>> Андрей Антонов,
>>>> инженер-программист отдела
>>> информационных технологий и
>>> программирования,
>>>> компания «Импульс М»
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list
>>> (pgadmin-hackers@postgresql.org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers [2]
>>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com [3]
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com [4]
>>> The Enterprise PostgreSQL Company
>>
>> --
>>
>> AKSHAY JOSHI
>> PRINCIPAL SOFTWARE ENGINEER
>>
>> Phone: +91 20-3058-9517
>> Mobile: +91 976-788-8246
>
> --
>
> AKSHAY JOSHI
> PRINCIPAL SOFTWARE ENGINEER
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246
>
> Links:
> ------
> [1] https://github.com/postgres/pgadmin3/pull/11
> [2] http://www.postgresql.org/mailpref/pgadmin-hackers
> [3] http://pgsnake.blogspot.com
> [4] http://www.enterprisedb.com

--
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»
Вложения

Re: patch: fixing dublicates foreign-tables

От
Akshay Joshi
Дата:
Hi Andrej

Your patch looks good to me. During testing I came across one more issue when user select the existing foreign table and click on Properties menu entry in the "Foreign Server" combo box is blank. I have fixed the issue and attached is the patch with combined fix. 

Issue :- As per the code "SetValue()" method of the wxComboBox is called in case of existing foreign table, but in the documentation of the wxWidget it is mentioned that "For a combobox with wxCB_READONLY style the string must be in the combobox choices list otherwise the call to SetValue() is ignored"

Fix:- Insert the value of Foreign Servers before calling the "SetValue()" method.


On Tue, Dec 8, 2015 at 4:23 PM, Andrej Antonov <antonov@imp-m.ru> wrote:
hello, Akshay!

screenshot:

"Screenshot from 2015-12-08 13-43-54 with-labels.png" (as attachment file).

script to reproduce:



        CREATE FOREIGN DATA WRAPPER postgresql
          VALIDATOR postgresql_fdw_validator;

        CREATE SERVER film_server FOREIGN DATA WRAPPER postgresql OPTIONS (host 'foo', dbname 'foodb', port '5432');

        CREATE FOREIGN TABLE films1 (
            code        char(5) NOT NULL,
            title       varchar(40) NOT NULL,
            did         integer NOT NULL,
            date_prod   date,
            kind        varchar(10),
            len         interval hour to minute
        )
        SERVER film_server;

        CREATE FOREIGN TABLE films2 (
            code        char(5) NOT NULL,
            title       varchar(40) NOT NULL,
            did         integer NOT NULL,
            date_prod   date,
            kind        varchar(10),
            len         interval hour to minute
        )
        SERVER film_server;

        COMMENT ON FOREIGN TABLE films1 IS 'description A';
        COMMENT ON FOREIGN TABLE films2 IS 'description B';

        COMMENT ON COLUMN films1.code IS 'descr code A';
        COMMENT ON COLUMN films1.title IS 'descr title A';
        COMMENT ON COLUMN films1.did IS 'descr did A';
        COMMENT ON COLUMN films2.code IS 'descr code B';
        COMMENT ON COLUMN films2.title IS 'descr title B';
        COMMENT ON COLUMN films2.did IS 'descr did B';



Akshay Joshi писал 2015-12-08 13:21:
Hi Andrej

Can you please share the reproduction step of the issue that you have
fixed.

On Tue, Dec 8, 2015 at 11:15 AM, Akshay Joshi
<akshay.joshi@enterprisedb.com> wrote:

On Tue, Dec 8, 2015 at 11:09 AM, Dave Page <dpage@pgadmin.org>
wrote:

Akshay, can you review this please?

Sure, Dave.

2015-12-07 19:47 GMT+05:30 Andrej Antonov <antonov@imp-m.ru>:
fixing dublicates foreign-tables (see attachment file).

this email -- it is just copy of pull-request
https://github.com/postgres/pgadmin3/pull/11 [1] .

thanks in advance.

--
Андрей Антонов,
инженер-программист отдела
информационных технологий и
программирования,
компания «Импульс М»

--
Sent via pgadmin-hackers mailing list
(pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers [2]


--
Dave Page
Blog: http://pgsnake.blogspot.com [3]
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com [4]
The Enterprise PostgreSQL Company

--

AKSHAY JOSHI
PRINCIPAL SOFTWARE ENGINEER

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

AKSHAY JOSHI
PRINCIPAL SOFTWARE ENGINEER

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

 Links:
------
[1] https://github.com/postgres/pgadmin3/pull/11
[2] http://www.postgresql.org/mailpref/pgadmin-hackers
[3] http://pgsnake.blogspot.com
[4] http://www.enterprisedb.com

--
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Вложения

Сайт использует файлы cookie для корректной работы и повышения удобства. Нажимая кнопку «Принять» или продолжая пользоваться сайтом, вы соглашаетесь на их использование в соответствии с Политикой в отношении обработки cookie ООО «ППГ», в том числе на передачу данных из файлов cookie сторонним статистическим и рекламным службам. Вы можете управлять настройками cookie через параметры вашего браузера