Обсуждение: PATCH: remove redundant local variables
Hello. Please, take a look at this patch. There are several local variables, that obviously may be removed. -- Dmitriy Olshevskiy
Вложения
Sanket, could you review this please? Thanks. On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote: > Hello. > Please, take a look at this patch. There are several local variables, that > obviously may be removed. > > -- > Dmitriy Olshevskiy > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi Dave,
Sure I will.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
Sanket, could you review this please?
Thanks.> --
On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
> Hello.
> Please, take a look at this patch. There are several local variables, that
> obviously may be removed.
>
> --
> Dmitriy Olshevskiy
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
Patch looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi Dave,Sure I will.Regards,Sanket MehtaSr Software engineerEnterprisedbOn Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:Sanket, could you review this please?
Thanks.> --
On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
> Hello.
> Please, take a look at this patch. There are several local variables, that
> obviously may be removed.
>
> --
> Dmitriy Olshevskiy
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Ashesh, can you commit this please (if you agree it looks OK)? I don't have a working dev environment right now. On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote: > Hi Dave, > > Patch looks good to me. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta > <sanket.mehta@enterprisedb.com> wrote: >> >> Hi Dave, >> >> Sure I will. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote: >>> >>> Sanket, could you review this please? >>> >>> Thanks. >>> >>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> >>> wrote: >>> > Hello. >>> > Please, take a look at this patch. There are several local variables, >>> > that >>> > obviously may be removed. >>> > >>> > -- >>> > Dmitriy Olshevskiy >>> > >>> > >>> > >>> > -- >>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> > To make changes to your subscription: >>> > http://www.postgresql.org/mailpref/pgadmin-hackers >>> > >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Sure.
On Fri, May 22, 2015 at 5:18 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you commit this please (if you agree it looks OK)? I don't
have a working dev environment right now.
On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta<sanket.mehta@enterprisedb.com> wrote:
> Hi Dave,
>
> Patch looks good to me.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta
> <sanket.mehta@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Sure I will.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Sanket, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru>
>>> wrote:
>>> > Hello.
>>> > Please, take a look at this patch. There are several local variables,
>>> > that
>>> > obviously may be removed.
>>> >
>>> > --
>>> > Dmitriy Olshevskiy
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, May 22, 2015 at 5:30 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Sure.
On Fri, May 22, 2015 at 5:18 PM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you commit this please (if you agree it looks OK)? I don't
have a working dev environment right now.
On Thu, May 21, 2015 at 11:47 AM, Sanket Mehta<sanket.mehta@enterprisedb.com> wrote:
> Hi Dave,
>
> Patch looks good to me.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta
> <sanket.mehta@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Sure I will.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Thu, May 21, 2015 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Sanket, could you review this please?
>>>
>>> Thanks.
>>>
>>> On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru>
>>> wrote:
>>> > Hello.
>>> > Please, take a look at this patch. There are several local variables,
>>> > that
>>> > obviously may be removed.
>>> >
>>> > --
>>> > Dmitriy Olshevskiy
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company