Обсуждение: pgAdmin III commit: Remove the "Apply" buttons from the function, view
Remove the "Apply" buttons from the function, view package and external table dialogues. This patch (against master) cleans up a number of issues in the browser code: - It fixes the collapsing tree issue by reverting patch 1 which attempted to fix a bug caused by patch 2. The bug in patch 2 has been fixed by partially reverting some code that attempted (badly) to re-display objects in the treeview after they had been moved to another schema. - Removes the few "Apply" buttons we had, and all the supporting code for consistency with other dialogues and to dissuade users from editing function code etc. in the dialogues (as we already try to do with a Guru Hint). - The removal of the "Apply" buttons means that patch 3 is no longer required, and has been reverted to simplify the code. - The removal of the "Apply" buttons also obsoletes another bug that caused a crash if renaming an object and then using the Apply button. Dinesh had been working on a patch for this issue which was > 20KB and made the browser code even more complex than it is now. Patch 1: http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=e97d351dcbc42a38f0054a81f37727d511087ffa Patch 2: http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=3e05c4d832e5658419094c34ce0ee6959bc1d85a Patch 3: http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cb5dba55dc491107e4152bd80ec496294e449934 Branch ------ REL-1_16_0_PATCHES Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a44ba3cbcc84b5727af589de3a4194b9e23cf1a8 Modified Files -------------- CHANGELOG | 4 + pgadmin/dlg/dlgClasses.cpp | 18 -- pgadmin/dlg/dlgExtTable.cpp | 9 - pgadmin/dlg/dlgFunction.cpp | 9 - pgadmin/dlg/dlgPackage.cpp | 13 -- pgadmin/dlg/dlgProperty.cpp | 109 +----------- pgadmin/dlg/dlgTrigger.cpp | 11 -- pgadmin/dlg/dlgView.cpp | 9 - pgadmin/frm/frmMain.cpp | 12 +- pgadmin/include/dlg/dlgClasses.h | 1 - pgadmin/include/dlg/dlgExtTable.h | 1 - pgadmin/include/dlg/dlgFunction.h | 3 - pgadmin/include/dlg/dlgPackage.h | 1 - pgadmin/include/dlg/dlgProperty.h | 4 - pgadmin/include/dlg/dlgTrigger.h | 1 - pgadmin/include/dlg/dlgView.h | 3 - pgadmin/include/frm/frmMain.h | 2 +- pgadmin/ui/dlgFunction.xrc | 9 +- pgadmin/ui/dlgPackage.xrc | 9 +- pgadmin/ui/dlgTrigger.xrc | 9 +- pgadmin/ui/dlgView.xrc | 9 +- pgadmin/ui/xrcDialogs.cpp | 346 ++++++++++++++++--------------------- 22 files changed, 167 insertions(+), 425 deletions(-)