Обсуждение: PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

Поиск
Список
Период
Сортировка

PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

От
Ashesh Vashi
Дата:
Hi Dave,

Please find the patches for the "Support for the Private Synonyms in EnterpriseDB 8.4" for trunk and REL_1_10_PATCHES branch.

--
Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company

Вложения

Re: PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

От
Magnus Hagander
Дата:
On Tue, Mar 23, 2010 at 09:14, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Dave,
> Please find the patches for the "Support for the Private Synonyms in
> EnterpriseDB 8.4" for trunk and REL_1_10_PATCHES branch.

Just as a point, I believe we have the same policy for backpatches as
the core project, which means a new feature like this doesn't get
backpatched. So that part of your work was wasted, I think :( for
trunk, of course, that doesn't apply :-)


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

От
Dave Page
Дата:
On Tue, Mar 23, 2010 at 8:14 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Dave,
> Please find the patches for the "Support for the Private Synonyms in
> EnterpriseDB 8.4" for trunk and REL_1_10_PATCHES branch.

Thanks - I'll review this. Note that this patch is for a new feature,
and thus won't be added to the 1.10 branch.



--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

Re: PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

От
Ashesh Vashi
Дата:
I understand. :-)



On Tue, Mar 23, 2010 at 1:56 PM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Mar 23, 2010 at 09:14, Ashesh Vashi
> Hi Dave,
> Please find the patches for the "Support for the Private Synonyms in
> EnterpriseDB 8.4" for trunk and REL_1_10_PATCHES branch.

Just as a point, I believe we have the same policy for backpatches as
the core project, which means a new feature like this doesn't get
backpatched. So that part of your work was wasted, I think :( for
trunk, of course, that doesn't apply :-)


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

От
Dave Page
Дата:
Hi Ashesh,

2010/3/23 Ashesh Vashi <ashesh.vashi@enterprisedb.com>:
> Hi Dave,
> Please find the patches for the "Support for the Private Synonyms in EnterpriseDB 8.4" for trunk and REL_1_10_PATCHES
branch.

I've just been playing with this, and found a couple of issues:

- There is no 'Synonyms' option on the Display tab of the options dialogue.

- If you right-click the schema, and select 'New Object', Synonym is
not listed.

Other than that, it looks good to me.

Thanks!

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

Re: PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

От
Ashesh Vashi
Дата:
Hi Dave,

Please find the updated patch.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company

On Thu, Mar 25, 2010 at 2:21 AM, Dave Page <dave.page@enterprisedb.com> wrote:
Hi Ashesh,

2010/3/23 Ashesh Vashi <ashesh.vashi@enterprisedb.com>:
> Hi Dave,
> Please find the patches for the "Support for the Private Synonyms in EnterpriseDB 8.4" for trunk and REL_1_10_PATCHES branch.

I've just been playing with this, and found a couple of issues:

- There is no 'Synonyms' option on the Display tab of the options dialogue.

- If you right-click the schema, and select 'New Object', Synonym is
not listed.

Other than that, it looks good to me.

Thanks!

Вложения

Re: PATCH: Added support for the Private Synonyms for EnterpriseDB 8.4

От
Dave Page
Дата:
On Thu, Mar 25, 2010 at 4:31 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Dave,
> Please find the updated patch.

Thanks - applied to SVN Trunk.


--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com