Обсуждение: New colour selector

Поиск
Список
Период
Сортировка

New colour selector

От
Dave Page
Дата:
Hi Guillaume,

I just went to add a server in a pgAdmin build from SVN trunk and
noticed that the new colour selector doesn't work so well on Mac. You
can't see easily what the selected colour is - it just looks like a
big ugly button. Further, when you click it for the first time, the
settings are such that it's far from obvious how to select a colour
other than black (actually, you need to set the vertical slider on the
right to the top to see solid colours).

Please see the attached screenshots.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Вложения

Re: New colour selector

От
Ashesh Vashi
Дата:
Hi Dave,

In your second screen-shots:
You need to shift the scroll button up which will make other colors visible (as per my knowledge).

On Mon, Jan 18, 2010 at 1:53 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi Guillaume,

I just went to add a server in a pgAdmin build from SVN trunk and
noticed that the new colour selector doesn't work so well on Mac. You
can't see easily what the selected colour is - it just looks like a
big ugly button. Further, when you click it for the first time, the
settings are such that it's far from obvious how to select a colour
other than black (actually, you need to set the vertical slider on the
right to the top to see solid colours).

Please see the attached screenshots.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: New colour selector

От
Dave Page
Дата:
On Mon, Jan 18, 2010 at 9:33 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Dave,
> In your second screen-shots:
> You need to shift the scroll button up which will make other colors visible
> (as per my knowledge).


Yeah, I said that below (the bit about the vertical slider) :-)

But... even though it works, it's not obvious, and it's not user-friendly.

> On Mon, Jan 18, 2010 at 1:53 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi Guillaume,
>>
>> I just went to add a server in a pgAdmin build from SVN trunk and
>> noticed that the new colour selector doesn't work so well on Mac. You
>> can't see easily what the selected colour is - it just looks like a
>> big ugly button. Further, when you click it for the first time, the
>> settings are such that it's far from obvious how to select a colour
>> other than black (actually, you need to set the vertical slider on the
>> right to the top to see solid colours).
>>
>> Please see the attached screenshots.
>>
>> --
>> Dave Page
>> EnterpriseDB UK: http://www.enterprisedb.com
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>



--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Re: New colour selector

От
Guillaume Lelarge
Дата:
Le 18/01/2010 10:40, Dave Page a écrit :
> On Mon, Jan 18, 2010 at 9:33 AM, Ashesh Vashi
> <ashesh.vashi@enterprisedb.com> wrote:
>> Hi Dave,
>> In your second screen-shots:
>> You need to shift the scroll button up which will make other colors visible
>> (as per my knowledge).
>
>
> Yeah, I said that below (the bit about the vertical slider) :-)
>
> But... even though it works, it's not obvious, and it's not user-friendly.
>

Sorry about this. I don't have access to my Mac right now, but will work
on this ASAP.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: New colour selector

От
Dave Page
Дата:
On Sun, Feb 14, 2010 at 9:27 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 18/01/2010 09:23, Dave Page a écrit :
>> [...]
>> I just went to add a server in a pgAdmin build from SVN trunk and
>> noticed that the new colour selector doesn't work so well on Mac. You
>> can't see easily what the selected colour is - it just looks like a
>> big ugly button. Further, when you click it for the first time, the
>> settings are such that it's far from obvious how to select a colour
>> other than black (actually, you need to set the vertical slider on the
>> right to the top to see solid colours).
>>
>> Please see the attached screenshots.
>>
>
> It seems to be a wxWidgets/Mac OS X bug. I've found a thread on wx-users
> (see
> http://groups.google.fr/group/wx-users/browse_frm/thread/57640f7f187f9c38/f4d36364fa47dafd)
> in which this issue is discussed.
>
> They said the native control is borked. So, they added an option to have
> a better generic control. You need to set wxCLRBTN_USES_BMP_BUTTON to 1
> to have it. I tried this and it works (minor a change to a header file).
>
> Anyways, I sent them an email to fix the header issue and to know if we
> really need to set this option. I'm waiting for their answer.
>
> Do you think that the wxCLRBTN_USES_BMP_BUTTON solution is possible for
> us? I mean, can you set it before you build Mac OS X release of pgAdmin?

Does it need to be set when wxWidgets is built?

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Re: New colour selector

От
Guillaume Lelarge
Дата:
Le 18/01/2010 09:23, Dave Page a écrit :
> [...]
> I just went to add a server in a pgAdmin build from SVN trunk and
> noticed that the new colour selector doesn't work so well on Mac. You
> can't see easily what the selected colour is - it just looks like a
> big ugly button. Further, when you click it for the first time, the
> settings are such that it's far from obvious how to select a colour
> other than black (actually, you need to set the vertical slider on the
> right to the top to see solid colours).
>
> Please see the attached screenshots.
>

It seems to be a wxWidgets/Mac OS X bug. I've found a thread on wx-users
(see
http://groups.google.fr/group/wx-users/browse_frm/thread/57640f7f187f9c38/f4d36364fa47dafd)
in which this issue is discussed.

They said the native control is borked. So, they added an option to have
a better generic control. You need to set wxCLRBTN_USES_BMP_BUTTON to 1
to have it. I tried this and it works (minor a change to a header file).

Anyways, I sent them an email to fix the header issue and to know if we
really need to set this option. I'm waiting for their answer.

Do you think that the wxCLRBTN_USES_BMP_BUTTON solution is possible for
us? I mean, can you set it before you build Mac OS X release of pgAdmin?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: New colour selector

От
Guillaume Lelarge
Дата:
Le 14/02/2010 11:09, Dave Page a écrit :
> On Sun, Feb 14, 2010 at 9:27 AM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 18/01/2010 09:23, Dave Page a écrit :
>>> [...]
>>> I just went to add a server in a pgAdmin build from SVN trunk and
>>> noticed that the new colour selector doesn't work so well on Mac. You
>>> can't see easily what the selected colour is - it just looks like a
>>> big ugly button. Further, when you click it for the first time, the
>>> settings are such that it's far from obvious how to select a colour
>>> other than black (actually, you need to set the vertical slider on the
>>> right to the top to see solid colours).
>>>
>>> Please see the attached screenshots.
>>>
>>
>> It seems to be a wxWidgets/Mac OS X bug. I've found a thread on wx-users
>> (see
>> http://groups.google.fr/group/wx-users/browse_frm/thread/57640f7f187f9c38/f4d36364fa47dafd)
>> in which this issue is discussed.
>>
>> They said the native control is borked. So, they added an option to have
>> a better generic control. You need to set wxCLRBTN_USES_BMP_BUTTON to 1
>> to have it. I tried this and it works (minor a change to a header file).
>>
>> Anyways, I sent them an email to fix the header issue and to know if we
>> really need to set this option. I'm waiting for their answer.
>>
>> Do you think that the wxCLRBTN_USES_BMP_BUTTON solution is possible for
>> us? I mean, can you set it before you build Mac OS X release of pgAdmin?
>
> Does it need to be set when wxWidgets is built?
>

AFAICT, yes.

I see two possible ways to get rid of this issue:
 1. we use the wxCLRBTN_USES_BMP_BUTTON solution
 2. we create our own ctlColourPicker

I'm more and more inclined to say we should choose the second one. The
first one is less work (at least for me), but the second one allows us
to be sure we have no issues with this kind of control.

I can work on the second one, it's pretty much what I already did for
the wxComboBox with the bitmap. Shouldn't be hard to do.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: New colour selector

От
Dave Page
Дата:
On Sun, Feb 14, 2010 at 1:18 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> I'm more and more inclined to say we should choose the second one. The
> first one is less work (at least for me), but the second one allows us
> to be sure we have no issues with this kind of control.
>
> I can work on the second one, it's pretty much what I already did for
> the wxComboBox with the bitmap. Shouldn't be hard to do.

That would be preferrable to having to require a special build of wx.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Re: New colour selector

От
Guillaume Lelarge
Дата:
Le 14/02/2010 15:32, Dave Page a écrit :
> On Sun, Feb 14, 2010 at 1:18 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> I'm more and more inclined to say we should choose the second one. The
>> first one is less work (at least for me), but the second one allows us
>> to be sure we have no issues with this kind of control.
>>
>> I can work on the second one, it's pretty much what I already did for
>> the wxComboBox with the bitmap. Shouldn't be hard to do.
>
> That would be preferrable to having to require a special build of wx.
>

I don't like having custom widgets, but I also think you're right. I'll
apply Maga's patch ASAP, and then work on this new control.

Thanks for noticing the issue and for your comments.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com