Обсуждение: Ticket 116: application_name new 8.5 feature

Поиск
Список
Период
Сортировка

Ticket 116: application_name new 8.5 feature

От
Guillaume Lelarge
Дата:
Hi,

You'll find attached a patch that makes use of this new 8.5 feature. The
frmStatus window handles a new column on the activity report to show the
application name. Each pgAdmin's window who owns a connection has a
specific name (for example "browser (pgAdmin)", "config editor
(pgAdmin)", "edit grid (pgAdmin)", ...). I don't think we need to add
pgAdmin's release because there are probably already too much details.

Comments?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Вложения

Re: Ticket 116: application_name new 8.5 feature

От
Magnus Hagander
Дата:
2009/12/28 Guillaume Lelarge <guillaume@lelarge.info>:
> Hi,
>
> You'll find attached a patch that makes use of this new 8.5 feature. The
> frmStatus window handles a new column on the activity report to show the
> application name. Each pgAdmin's window who owns a connection has a
> specific name (for example "browser (pgAdmin)", "config editor
> (pgAdmin)", "edit grid (pgAdmin)", ...). I don't think we need to add
> pgAdmin's release because there are probably already too much details.
>
> Comments?

Looks good!

I'd much rather have it say "pgAdmin (browser)" etc, though, instead
of "browser (pgAdmin)". Really, the important thing for me as a dba to
know is that it's pgAdmin, so that should be the first and obvious
text.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: Ticket 116: application_name new 8.5 feature

От
Guillaume Lelarge
Дата:
Le 28/12/2009 13:57, Magnus Hagander a écrit :
> 2009/12/28 Guillaume Lelarge <guillaume@lelarge.info>:
>> Hi,
>>
>> You'll find attached a patch that makes use of this new 8.5 feature. The
>> frmStatus window handles a new column on the activity report to show the
>> application name. Each pgAdmin's window who owns a connection has a
>> specific name (for example "browser (pgAdmin)", "config editor
>> (pgAdmin)", "edit grid (pgAdmin)", ...). I don't think we need to add
>> pgAdmin's release because there are probably already too much details.
>>
>> Comments?
>
> Looks good!
>

Thanks.

> I'd much rather have it say "pgAdmin (browser)" etc, though, instead
> of "browser (pgAdmin)". Really, the important thing for me as a dba to
> know is that it's pgAdmin, so that should be the first and obvious
> text.
>

OK. Quite easy to do :)


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Re: Ticket 116: application_name new 8.5 feature

От
Dave Page
Дата:
On Mon, Dec 28, 2009 at 12:47 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> You'll find attached a patch that makes use of this new 8.5 feature. The
> frmStatus window handles a new column on the activity report to show the
> application name. Each pgAdmin's window who owns a connection has a
> specific name (for example "browser (pgAdmin)", "config editor
> (pgAdmin)", "edit grid (pgAdmin)", ...). I don't think we need to add
> pgAdmin's release because there are probably already too much details.
>
> Comments?

Much prefer "pgAdmin - xxx", eg:

pgAdmin - Browser
pgAdmin - Query Tool

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Re: Ticket 116: application_name new 8.5 feature

От
Guillaume Lelarge
Дата:
Le 28/12/2009 20:10, Dave Page a écrit :
> On Mon, Dec 28, 2009 at 12:47 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Hi,
>>
>> You'll find attached a patch that makes use of this new 8.5 feature. The
>> frmStatus window handles a new column on the activity report to show the
>> application name. Each pgAdmin's window who owns a connection has a
>> specific name (for example "browser (pgAdmin)", "config editor
>> (pgAdmin)", "edit grid (pgAdmin)", ...). I don't think we need to add
>> pgAdmin's release because there are probably already too much details.
>>
>> Comments?
>
> Much prefer "pgAdmin - xxx", eg:
>
> pgAdmin - Browser
> pgAdmin - Query Tool
>

Done. I suppose Magnus will agree on this, the word pgAdmin is still
first in the application name.

New patch attached. I'll apply it tomorrow night if no one objects.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Вложения