Обсуждение: Fwd: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME

Hi,

This is a bug report from Ubuntu's Launchpad. I think they are right, and
wonder why we use the Alt-F4 shortcut. Probably something that was done in the
first releases of pgAdmin?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com
Public bug reported:

Binary package hint: pgadmin3


The usual keyboard shortcut for closing a window is Ctrl+W
The usual keyboard shortcut for closing an application is Ctrl+Q.

Pgadmin3 uses Alt+F4 for both.  For consistency with the rest of Ubuntu
this should be changed.

** Affects: pgadmin3 (Ubuntu)
     Importance: Undecided
         Status: New

--
Keyboard shortcuts for closing window / application inconsistent with GNOME
https://bugs.launchpad.net/bugs/484145
You received this bug notification because you are subscribed to
pgadmin3 in ubuntu.

2009/11/19 Guillaume Lelarge <guillaume@lelarge.info>:
> Hi,
>
> This is a bug report from Ubuntu's Launchpad. I think they are right, and
> wonder why we use the Alt-F4 shortcut. Probably something that was done in the
> first releases of pgAdmin?

Umm, because Alt-F4 is the key that does it on Windows?

But yeah, it'd certainly be better to use the platform defaults,
unless there is a specific reason (wx compataibility? :P) not to.

//Magnus


> ---------- Forwarded message ----------
> From: Arno Peters <a.w.peters@ieee.org>
> To: guillaume@lelarge.info
> Date: Tue, 17 Nov 2009 11:35:14 -0000
> Subject: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME
> Public bug reported:
>
> Binary package hint: pgadmin3
>
>
> The usual keyboard shortcut for closing a window is Ctrl+W
> The usual keyboard shortcut for closing an application is Ctrl+Q.
>
> Pgadmin3 uses Alt+F4 for both.  For consistency with the rest of Ubuntu
> this should be changed.
>
> ** Affects: pgadmin3 (Ubuntu)
>     Importance: Undecided
>         Status: New
>
> --
> Keyboard shortcuts for closing window / application inconsistent with GNOME
> https://bugs.launchpad.net/bugs/484145
> You received this bug notification because you are subscribed to
> pgadmin3 in ubuntu.
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

On Thu, Nov 19, 2009 at 4:05 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> This is a bug report from Ubuntu's Launchpad. I think they are right, and
> wonder why we use the Alt-F4 shortcut. Probably something that was done in the
> first releases of pgAdmin?

Probably - but also we've tried to standardise the keys in pgAdmin
across platforms, to help users that run different OSs.

I guess what we need is a way for users to configure their own
shortcuts, or to swap between different sets no matter what they're
running, so they can either be platform compatible, or pgAdmin
compatible.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Le jeudi 19 novembre 2009 à 08:11:19, Magnus Hagander a écrit :
> 2009/11/19 Guillaume Lelarge <guillaume@lelarge.info>:
> > Hi,
> >
> > This is a bug report from Ubuntu's Launchpad. I think they are right, and
> > wonder why we use the Alt-F4 shortcut. Probably something that was done
> > in the first releases of pgAdmin?
>
> Umm, because Alt-F4 is the key that does it on Windows?
>
> But yeah, it'd certainly be better to use the platform defaults,
> unless there is a specific reason (wx compataibility? :P) not to.
>

I probably didn't explain enough. Alt-F4 is the default at least on Windows
and Linux (KDE). But it is a window manager shortcut, not an application one.

The usual default shortcuts are Ctrl-Q to quit an application and Ctrl-W to
close a window. We have right now the Alt-F4 shortcut on our Quit item in the
File menu. Something that no other application does AFAICT.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Le jeudi 19 novembre 2009 à 08:12:29, Dave Page a écrit :
> On Thu, Nov 19, 2009 at 4:05 PM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > Hi,
> >
> > This is a bug report from Ubuntu's Launchpad. I think they are right, and
> > wonder why we use the Alt-F4 shortcut. Probably something that was done
> > in the first releases of pgAdmin?
>
> Probably - but also we've tried to standardise the keys in pgAdmin
> across platforms, to help users that run different OSs.
>

AFAICT, Ctrl-Q and Ctrl-W are far more standardize on the different OSs than
Alt-F4. I have a bad memory, but I really don't remember using Alt-F4 on Mac
OS X.

> I guess what we need is a way for users to configure their own
> shortcuts, or to swap between different sets no matter what they're
> running, so they can either be platform compatible, or pgAdmin
> compatible.
>

Could be. But it seems to me that our defaults are weird.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

On Thu, Nov 19, 2009 at 4:16 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> I probably didn't explain enough. Alt-F4 is the default at least on Windows
> and Linux (KDE). But it is a window manager shortcut, not an application one.
>
> The usual default shortcuts are Ctrl-Q to quit an application and Ctrl-W to
> close a window. We have right now the Alt-F4 shortcut on our Quit item in the
> File menu. Something that no other application does AFAICT.

Usual if you're a Windows or KDE user then - probably 90% of the world or more!

How do other wxWidgets apps do it? I'd be surprised if they set their
own shortcuts based on the window manager that was in use at runtime.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Le jeudi 19 novembre 2009 à 08:20:14, Dave Page a écrit :
> On Thu, Nov 19, 2009 at 4:16 PM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > I probably didn't explain enough. Alt-F4 is the default at least on
> > Windows and Linux (KDE). But it is a window manager shortcut, not an
> > application one.
> >
> > The usual default shortcuts are Ctrl-Q to quit an application and Ctrl-W
> > to close a window. We have right now the Alt-F4 shortcut on our Quit item
> > in the File menu. Something that no other application does AFAICT.
>
> Usual if you're a Windows or KDE user then - probably 90% of the world or
>  more!
>

I'm quite sure Microsoft Word (and others) display Ctrl-Q on its Quit item,
and not Alt-F4. I can't check right now, but will do tonight.

> How do other wxWidgets apps do it? I'd be surprised if they set their
> own shortcuts based on the window manager that was in use at runtime.
>

Depends on the sample you look at it. I've seen Alt-X and Ctrl-Q.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Le jeudi 19 novembre 2009 à 08:19:06, Guillaume Lelarge a écrit :
> Le jeudi 19 novembre 2009 à 08:12:29, Dave Page a écrit :
> > On Thu, Nov 19, 2009 at 4:05 PM, Guillaume Lelarge
> >
> > <guillaume@lelarge.info> wrote:
> > > Hi,
> > >
> > > This is a bug report from Ubuntu's Launchpad. I think they are right,
> > > and wonder why we use the Alt-F4 shortcut. Probably something that was
> > > done in the first releases of pgAdmin?
> >
> > Probably - but also we've tried to standardise the keys in pgAdmin
> > across platforms, to help users that run different OSs.
>
> AFAICT, Ctrl-Q and Ctrl-W are far more standardize on the different OSs
>  than Alt-F4. I have a bad memory, but I really don't remember using Alt-F4
>  on Mac OS X.
>

Here is a patch that fixes this. Try it, you'll be able to use Alt-F4 or Ctrl-
Q on the main window and Alt-F4 or Ctrl-W on the other ones (querytool for
example). Only Ctrl-Q and Ctrl-W are displayed in the Quit menu item.

Other comments?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Le jeudi 19 novembre 2009 à 21:57:43, Guillaume Lelarge a écrit :
> Le jeudi 19 novembre 2009 à 08:19:06, Guillaume Lelarge a écrit :
> > Le jeudi 19 novembre 2009 à 08:12:29, Dave Page a écrit :
> > > On Thu, Nov 19, 2009 at 4:05 PM, Guillaume Lelarge
> > >
> > > <guillaume@lelarge.info> wrote:
> > > > Hi,
> > > >
> > > > This is a bug report from Ubuntu's Launchpad. I think they are right,
> > > > and wonder why we use the Alt-F4 shortcut. Probably something that
> > > > was done in the first releases of pgAdmin?
> > >
> > > Probably - but also we've tried to standardise the keys in pgAdmin
> > > across platforms, to help users that run different OSs.
> >
> > AFAICT, Ctrl-Q and Ctrl-W are far more standardize on the different OSs
> >  than Alt-F4. I have a bad memory, but I really don't remember using
> > Alt-F4 on Mac OS X.
>
> Here is a patch that fixes this. Try it, you'll be able to use Alt-F4 or
>  Ctrl- Q on the main window and Alt-F4 or Ctrl-W on the other ones
>  (querytool for example). Only Ctrl-Q and Ctrl-W are displayed in the Quit
>  menu item.
>
> Other comments?
>

Hmmm, no comments on this patch? usually, I would commit it right away :) but
as there were objections on the issue, I don't know what I should do.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

On Wed, Dec 2, 2009 at 10:42 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:

> Hmmm, no comments on this patch? usually, I would commit it right away :) but
> as there were objections on the issue, I don't know what I should do.

If it works as you describe, then of course, no objections from me.


--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Le jeudi 3 décembre 2009 à 09:34:43, Dave Page a écrit :
> On Wed, Dec 2, 2009 at 10:42 PM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > Hmmm, no comments on this patch? usually, I would commit it right away :)
> > but as there were objections on the issue, I don't know what I should do.
>
> If it works as you describe, then of course, no objections from me.
>

I've commited it in trunk. I'm not sure this is something I want to/can commit
to the 1.10 branch. Any opinion on this?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

On Thu, Dec 3, 2009 at 8:57 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le jeudi 3 décembre 2009 à 09:34:43, Dave Page a écrit :
>> On Wed, Dec 2, 2009 at 10:42 PM, Guillaume Lelarge
>>
>> <guillaume@lelarge.info> wrote:
>> > Hmmm, no comments on this patch? usually, I would commit it right away :)
>> > but as there were objections on the issue, I don't know what I should do.
>>
>> If it works as you describe, then of course, no objections from me.
>>
>
> I've commited it in trunk. I'm not sure this is something I want to/can commit
> to the 1.10 branch. Any opinion on this?

Borderline case. As it doesn't stop the existing keys from working, I
think it's OK.

BTW, I (finally) expect to cut 1.10.1 today - probably later this morning.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Le jeudi 3 décembre 2009 à 10:19:42, Dave Page a écrit :
> On Thu, Dec 3, 2009 at 8:57 AM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > Le jeudi 3 décembre 2009 à 09:34:43, Dave Page a écrit :
> >> On Wed, Dec 2, 2009 at 10:42 PM, Guillaume Lelarge
> >>
> >> <guillaume@lelarge.info> wrote:
> >> > Hmmm, no comments on this patch? usually, I would commit it right away
> >> > :) but as there were objections on the issue, I don't know what I
> >> > should do.
> >>
> >> If it works as you describe, then of course, no objections from me.
> >
> > I've commited it in trunk. I'm not sure this is something I want to/can
> > commit to the 1.10 branch. Any opinion on this?
>
> Borderline case. As it doesn't stop the existing keys from working, I
> think it's OK.
>

OK, I'm doing it this morning (waiting for the compile and test to finish).

> BTW, I (finally) expect to cut 1.10.1 today - probably later this morning.
>

That's a great news.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com