Обсуждение: Re: Improved copying from Edit Data Grid - rough

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Edward Di Geronimo Jr.
> Sent: 03 February 2006 20:02
> To: Magnus Hagander
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Improved copying from Edit
> Data Grid - rough
>
> Magnus Hagander wrote:
>
> >It think the quoting used when copy here should be the one from Copy
> >Quoting and not Export Quoting. I actually had it on my list
> to do that.
> >While you're working in taht code anyway, maybe do that while at it?
> >
> >
> Ok, I went back and did that as well. While in the process, I noticed
> that the setting to quote only strings also resulted in numbers being
> quoted. I redid the logic to fix that.
>
> >Does this also fix the complete weirdness that you can have
> *both* a row
> >*and* a cell in a different row selected at the same time? That keeps
> >throwing me off all the time.
> >
> >
> I didn't change the selection behavior at all, only the copy behavior.
>
> This version of the patch cleans up the code from my last patch. I
> changed the 3 overloaded versions of GetExportLine so that only 1
> version does the real work. The other two versions simply modify the
> input and call the real version.
>
> One other addition in this version - if you hit copy without
> any cells
> highlighted, it will copy the cell the cursor is in.

Sorry for taking a while to get to this.

Patch applied, with a minor change to make a couple of ints unsigned to
avoid compiler warnings. If you'd like to look at adding similar
functionality to the query tool, that'd be great :-)

Thanks Ed.

Regards, Dave.

Dave Page wrote:

>  If you'd like to look at adding similar
> functionality to the query tool, that'd be great :-)

Please note that the query tool output needs major redesign to use a
virtual control; the current (wx) implementation is dead slow on some
platforms.

Regards,
Andreas

Andreas Pflug wrote:

> Please note that the query tool output needs major redesign to use a
> virtual control; the current (wx) implementation is dead slow on some
> platforms.

Have any pointers on where I can find out more information on what needs
to be done?

Ed