Re: [PATCH] psql: Add tab-complete for optional view parameters

Thanks for the review!

On 12/8/22 12:19, Melih Mutlu wrote:
> Hi Christoph,
> 
> I just took a quick look at your patch.
> Some suggestions:
> 
>     +   else if (Matches("ALTER", "VIEW", MatchAny, "SET", "("))
>     +       COMPLETE_WITH_LIST(view_optional_parameters);
>     +   /* ALTER VIEW xxx RESET ( yyy , ... ) */
>     +   else if (Matches("ALTER", "VIEW", MatchAny, "RESET", "("))
>     +       COMPLETE_WITH_LIST(view_optional_parameters);
> 
> 
> What about combining these two cases into one like Matches("ALTER", 
> "VIEW", MatchAny, "SET|RESET", "(") ?
Good thinking, incorporated that into v2.
While at it, I also added completion for the values of the SET 
parameters, since that is useful as well.

> 
>          /* ALTER VIEW <name> */
>          else if (Matches("ALTER", "VIEW", MatchAny))
>              COMPLETE_WITH("ALTER COLUMN", "OWNER TO", "RENAME",
>                            "SET SCHEMA");
> 
> 
> Also seems like SET and RESET don't get auto-completed for "ALTER VIEW 
> <name>".
> I think it would be nice to include those missing words.
That is already contained in the patch:

@@ -2139,7 +2146,7 @@ psql_completion(const char *text, int start, int end)
      /* ALTER VIEW <name> */
      else if (Matches("ALTER", "VIEW", MatchAny))
          COMPLETE_WITH("ALTER COLUMN", "OWNER TO", "RENAME",
-                      "SET SCHEMA");
+                      "SET SCHEMA", "SET (", "RESET (");

Thanks,
Christoph