Re: MSVC vs Perl

On 2022-11-26 Sa 16:25, Andrew Dunstan wrote:
> On 2022-11-26 Sa 16:05, Andres Freund wrote:
>> Hi,
>>
>> On 2022-11-26 09:43:19 -0500, Andrew Dunstan wrote:
>>> OK, so this cures the problem for drongo:
>>>
>>>
>>> diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
>>> index 83a3e40425..dc6b94b74f 100644
>>> --- a/src/tools/msvc/Mkvcbuild.pm
>>> +++ b/src/tools/msvc/Mkvcbuild.pm
>>> @@ -707,6 +707,7 @@ sub mkvcbuild
>>>                 print "CFLAGS recommended by Perl: $Config{ccflags}\n";
>>>                 print "CFLAGS to compile embedded Perl: ",
>>>                   (join ' ', map { "-D$_" } @perl_embed_ccflags), "\n";
>>> +               push @perl_embed_ccflags,'NO_THREAD_SAFE_LOCALE';
>>>                 foreach my $f (@perl_embed_ccflags)
>>>                 {
>>>                         $plperl->AddDefine($f);
>> This likely is just a test patch, in case it is not, it seems we should add
>> NO_THREAD_SAFE_LOCALE to @perl_embed_ccflags before printing it.
> Sure



OK, pushed something like that, after testing that it didn't break my
remaining ActiveState instance.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com