Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pendingsolution of its timing is

>> If the test must run even when postgres doesn't, it is a little bit 
>> hard as a starting assumption for a benchmarking tool:-(
>
> I'm unsure what the point of this is.  It's not like we discussing
> removing pgbench, we're talking about an unreliable test.

My sentence was probably not very clear.

I just meant that devising a coverage test which does not fail when the 
benchmarking tool is not able to run because of load/valgrind/... is kind 
of hard.

Anything even loosely related to time, here having a few simple SELECT 
transactions over 2 seconds and a few printf into a file or stdout every 
second, can always fail if conditions are bad enough.

So this means somehow giving up on coverage, because of one host which can 
fail under very unusual testing conditions once in a while.

I would prefer to keep the test and have a warning instead, something
like "ok, although a test which is allowed to rarely fail failed", but at 
least the feature are tested most of the time.

Sigh.

-- 
Fabien.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers