Re: pgbench - minor fix for meta command only scripts

Поиск
Список
Период
Сортировка
Искать
От
Fabien COELHO
Тема
Re: pgbench - minor fix for meta command only scripts
Дата
Msg-id
alpine.DEB.2.20.1609200702520.27432@lancre
Ответ на
Список
Дерево обсуждения
pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - minor fix for meta command only scripts Michael Paquier <michael.paquier@gmail.com>
Re: pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - minor fix for meta command only scripts Tom Lane <tgl@sss.pgh.pa.us>
Re: pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - minor fix for meta command only scripts Heikki Linnakangas <hlinnaka@iki.fi>
Re: pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - minor fix for meta command only scripts Heikki Linnakangas <hlinnaka@iki.fi>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Jeff Janes <jeff.janes@gmail.com>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Jeff Janes <jeff.janes@gmail.com>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Jeff Janes <jeff.janes@gmail.com>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Noah Misch <noah@leadboat.com>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Jeff Janes <jeff.janes@gmail.com>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] pgbench - minor fix for meta command only scripts Heikki Linnakangas <hlinnaka@iki.fi>

Hello Heikki,

> Yeah, it really is quite a mess. I tried to review your patch, and I think 
> it's correct, but I couldn't totally convince myself, because of the existing 
> messiness of the logic.

Alas:-(

> So I bit the bullet and started refactoring.

Wow!

> I came up with the attached. It refactors the logic in doCustom() into a 
> state machine.

Sounds good! This can only help.

> I think this is much clearer, what do you think?

I think that something was really needed. I'm going to review and test 
this patch very carefully, probably over next week-end, and report.

-- 
Fabien.


В списке pgsql-hackers по дате отправления
От: Ashish Tyagi
Дата:
От: Amit Kapila
Дата:
FAQ