Re: pgbench - minor fix for meta command only scripts

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: pgbench - minor fix for meta command only scripts
Дата
Msg-id alpine.DEB.2.20.1609200702520.27432@lancre
обсуждение исходный текст
Ответ на Re: pgbench - minor fix for meta command only scripts  (Heikki Linnakangas <hlinnaka@iki.fi>)
Список pgsql-hackers
Hello Heikki,

> Yeah, it really is quite a mess. I tried to review your patch, and I think 
> it's correct, but I couldn't totally convince myself, because of the existing 
> messiness of the logic.

Alas:-(

> So I bit the bullet and started refactoring.

Wow!

> I came up with the attached. It refactors the logic in doCustom() into a 
> state machine.

Sounds good! This can only help.

> I think this is much clearer, what do you think?

I think that something was really needed. I'm going to review and test 
this patch very carefully, probably over next week-end, and report.

-- 
Fabien.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ashish Tyagi
Дата:
Сообщение: Re: Improvements in psql hooks for variables
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: WIP: Covering + unique indexes.