Re: Refactoring pgbench.c
От
Fabien COELHO
Тема
Re: Refactoring pgbench.c
Дата
Msg-id
alpine.DEB.2.10.1506282025050.25959@sto
Ответ на
Re: Refactoring pgbench.c (Tomas Vondra)
Список
Дерево обсуждения
Refactoring pgbench.c Tatsuo Ishii <ishii@postgresql.org>
Re: Refactoring pgbench.c Fabien COELHO <coelho@cri.ensmp.fr>
Re: Refactoring pgbench.c Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Refactoring pgbench.c Tatsuo Ishii <ishii@postgresql.org>
Re: Refactoring pgbench.c Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Refactoring pgbench.c Fabien COELHO <coelho@cri.ensmp.fr>
Re: Refactoring pgbench.c Jeff Janes <jeff.janes@gmail.com>
>> This is kind of surprising to me that two people are against >> refactoring proposal (I understand that Fabien has pending patches for >> pgbench and that could be a motivation for this though). > > I think that's a misunderstanding. I'm not against refactoring - not at all, > and neither is Fabien I believe. Indeed I'm not, I was writing about splitting "pgbench.c" into several files. Although, as Tatsuo-san noted, I'm probably against a refactoring before the patches I already submitted get considered:-) Really refactoring would mean breaking apart the long functions, but these are long for some reasons (say global goto to handle errors...), so how to do something very useful on that line is not clear to me. -- Fabien.
В списке pgsql-hackers по дате отправления
От: Heikki Linnakangas
Дата: