Re: BUG #18483: Segmentation fault in tests modules

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: BUG #18483: Segmentation fault in tests modules
Дата
Msg-id
Zm_JoQRXNe6nWb7N@paquier.xyz
Ответ на
Re: BUG #18483: Segmentation fault in tests modules (Michael Paquier)
Список
Дерево обсуждения
BUG #18483: Segmentation fault in tests modules PG Bug reporting form <noreply@postgresql.org>
Re: BUG #18483: Segmentation fault in tests modules Masahiko Sawada <sawada.mshk@gmail.com>
Re: BUG #18483: Segmentation fault in tests modules Masahiko Sawada <sawada.mshk@gmail.com>
Re: BUG #18483: Segmentation fault in tests modules Michael Paquier <michael@paquier.xyz>
Re: BUG #18483: Segmentation fault in tests modules Michael Paquier <michael@paquier.xyz>
Re: BUG #18483: Segmentation fault in tests modules Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #18483: Segmentation fault in tests modules Michael Paquier <michael@paquier.xyz>
Re: BUG #18483: Segmentation fault in tests modules Alexander Lakhin <exclusion@gmail.com>
Re: BUG #18483: Segmentation fault in tests modules Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #18483: Segmentation fault in tests modules Alexander Lakhin <exclusion@gmail.com>
Re: BUG #18483: Segmentation fault in tests modules Michael Paquier <michael@paquier.xyz>
Re: BUG #18483: Segmentation fault in tests modules Alexander Lakhin <exclusion@gmail.com>
Re: BUG #18483: Segmentation fault in tests modules Michael Paquier <michael@paquier.xyz>
Re: BUG #18483: Segmentation fault in tests modules Alexander Lakhin <exclusion@gmail.com>
Re: BUG #18483: Segmentation fault in tests modules Michael Paquier <michael@paquier.xyz>
Re: BUG #18483: Segmentation fault in tests modules John Naylor <johncnaylorls@gmail.com> 
On Mon, Jun 10, 2024 at 02:50:33PM +0900, Michael Paquier wrote:
> On Sun, Jun 09, 2024 at 03:00:00PM +0300, Alexander Lakhin wrote:
>> 4)
>> I guess, make_tuple_indirect() could be improved with:
>>                 /* only work on existing, not-null varlenas */
>>                 if (TupleDescAttr(tupdesc, i)->attisdropped ||
>>                         nulls[i] ||
>> -                       TupleDescAttr(tupdesc, i)->attlen != -1)
>> +                       TupleDescAttr(tupdesc, i)->attlen != -1 ||
>> +                       TupleDescAttr(tupdesc, i)->attstorage == TYPSTORAGE_PLAIN)
> 
> Fun.  True enough that this function is only here for toastable
> values, so that makes sense.

This one was indeed simple enough, so fixed it for now.
--
Michael
В списке pgsql-bugs по дате отправления
Предыдущее
От: Tom Lane
Дата:
Следующее
От: PG Bug reporting form
Дата:
FAQ