Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
От
Michael Paquier
Тема
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Дата
Msg-id
ZiXvxEKvh8cZpHFy@paquier.xyz
Ответ на
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS (Aleksander Alekseev)
Список
Дерево обсуждения
[PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Aleksander Alekseev <aleksander@timescale.com>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Richard Guo <guofenglinux@gmail.com>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Dean Rasheed <dean.a.rasheed@gmail.com>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Aleksander Alekseev <aleksander@timescale.com>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Dean Rasheed <dean.a.rasheed@gmail.com>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Aleksander Alekseev <aleksander@timescale.com>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Peter Eisentraut <peter@eisentraut.org>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Aleksander Alekseev <aleksander@timescale.com>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Peter Eisentraut <peter@eisentraut.org>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS Dean Rasheed <dean.a.rasheed@gmail.com>
On Fri, Apr 19, 2024 at 12:47:43PM +0300, Aleksander Alekseev wrote: > Thanks. I see a few pieces of code that use special FOO_NUMBER enum > values instead of a macro. Should we refactor these pieces > accordingly? PFA another patch. I don't see why not for the places you are changing here, we can be more consistent. Now, such changes are material for v18. -- Michael
В списке pgsql-hackers по дате отправления
