Re: [PATCH] clarify palloc comment on quote_literal_cstr

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] clarify palloc comment on quote_literal_cstr
Дата
Msg-id Z_SxywpaJsu1mRVG@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] clarify palloc comment on quote_literal_cstr  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Ответы Re: [PATCH] clarify palloc comment on quote_literal_cstr
Re: [PATCH] clarify palloc comment on quote_literal_cstr
Список pgsql-hackers
On Tue, Apr 08, 2025 at 08:47:53AM +0530, Ashutosh Bapat wrote:
> Thanks for addressing the comment.
>
> In PG code, we start a multiline comment with just /* on the first
> line and end with just */ on the last line. All the lines in-between
> start with * . Please check other comments in the file.
>
> I would write a., b. c. d. on separate lines.

Hmm.  I don't think that grouping all these details in the same
comment block is an improvement in this case compared to the first
version, where it is clear which part of the calculation applies to
what.  In short, I'm OK with how things are on HEAD.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления: