Re: [PATCH] clarify palloc comment on quote_literal_cstr
От
Michael Paquier
Тема
Re: [PATCH] clarify palloc comment on quote_literal_cstr
Дата
Msg-id
Z_SxywpaJsu1mRVG@paquier.xyz
Ответ на
Re: [PATCH] clarify palloc comment on quote_literal_cstr (Ashutosh Bapat)
Список
Дерево обсуждения
[PATCH] clarify palloc comment on quote_literal_cstr Steve Chavez <steve@supabase.io>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Michael Paquier <michael@paquier.xyz>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Steve Chavez <steve@supabase.io>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Michael Paquier <michael@paquier.xyz>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Michael Paquier <michael@paquier.xyz>
Re: [PATCH] clarify palloc comment on quote_literal_cstr Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
On Tue, Apr 08, 2025 at 08:47:53AM +0530, Ashutosh Bapat wrote: > Thanks for addressing the comment. > > In PG code, we start a multiline comment with just /* on the first > line and end with just */ on the last line. All the lines in-between > start with * . Please check other comments in the file. > > I would write a., b. c. d. on separate lines. Hmm. I don't think that grouping all these details in the same comment block is an improvement in this case compared to the first version, where it is clear which part of the calculation applies to what. In short, I'm OK with how things are on HEAD. -- Michael
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата: