RE: PGdoc: add missing ID attribute to create_subscription.sgml

Поиск
Список
Период
Сортировка
Искать
От
Hayato Kuroda (Fujitsu)
Тема
RE: PGdoc: add missing ID attribute to create_subscription.sgml
Дата
Msg-id
TYAPR01MB586610465B36702D7C70141AF58B9@TYAPR01MB5866.jpnprd01.prod.outlook.com
Ответ на
Список
Дерево обсуждения
PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Peter Smith <smithpb2250@gmail.com>
RE: PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Peter Smith <smithpb2250@gmail.com>
RE: PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Peter Smith <smithpb2250@gmail.com>
RE: PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Peter Smith <smithpb2250@gmail.com>
RE: PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Peter Smith <smithpb2250@gmail.com>
RE: PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Amit Kapila <amit.kapila16@gmail.com>
RE: PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Amit Kapila <amit.kapila16@gmail.com>
RE: PGdoc: add missing ID attribute to create_subscription.sgml "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Amit Kapila <amit.kapila16@gmail.com>
Re: PGdoc: add missing ID attribute to create_subscription.sgml Peter Smith <smithpb2250@gmail.com>
Dear Peter,

Thank you for reviewing! New patch set will be attached in later mail.

> ======
> Commit Message
> 
> 1.
> In commit ecb696, an XML ID attribute was added to only one varlistentry,
> creating inconsistency with the commit 78ee60. This commit adds XML ID
> attributes to all varlistentries in create_subscritpion.sgml for consistency.
> Additionally, links are added to refer subscription options, enhancing the
> readability of documents.
> 
> ~
> 
> 1a.
> Typo: create_subscritpion.sgml

Fixed.

> 1b.
> "to refer subscription options" --> "to refer to the subscription options"

Fixed.

> 2.
> -        streaming option (see optional parameters set by
> -        CREATE
> SUBSCRIPTION)
> +         linkend="sql-createsubscription-with-streaming">streaming
> 
> +        parameter of  linkend="sql-createsubscription">CREATE
> SUBSCRIPTION
> 
> Now, this link says "streaming parameter", but the very next paragraph
> refers to "streaming option". I think it is better to keep them the
> same (e.g. both say "streaming option").

I missed just next paragraph, I thought :-(.
Reverted the change, now it is called as "streaming option"

> doc/src/sgml/ref/alter_subscription.sgml
> 
> The SKIP part says "... enabling two_phase on subscriber.". I thought
> there could be a link for "two_phase" here (also "on subscriber" -->
> "on the subscriber").

Added.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED


В списке pgsql-hackers по дате отправления
От: Julien Rouhaud
Дата:
От: Hayato Kuroda (Fujitsu)
Дата:
FAQ