On Sat, 12 Nov 2022 at 12:12, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Fri, Nov 11, 2022 at 2:45 PM Japin Li <japinli@hotmail.com> wrote:
>> Maybe a wrong plural in XidInMvccSnapshot().
>>
>> * Make a quick range check to eliminate most XIDs without looking at the
>> * xip arrays.
>>
>> I think we should use "xip array" instead of "xip arrays".
>>
>
> I think here the comment is referring to both xip and subxip array, so
> it looks okay to me.
>
Yeah, it means xip in normal case, and subxip in recovery case.
>> Furthermore, if the snapshot is taken during recovery, the xip array is
>> empty, and we should check subxip array. How about changing "xip arrays"
>> to "xip or subxip array"?
>>
>
> I don't know if that is an improvement. I think we should stick to
> your initial proposed change.
Agreed. Let's focus on the initial proposed change.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.