Add IS_INDEX macro to brin and gist index

Поиск
Список
Период
Сортировка
Искать
От
Japin Li
Тема
Add IS_INDEX macro to brin and gist index
Дата
в 04:56:43
Msg-id
MEAPR01MB3031A889D4B3F610E9D2A3AFB68FA@MEAPR01MB3031.ausprd01.prod.outlook.com
Список
Дерево обсуждения
Add IS_INDEX macro to brin and gist index Japin Li <japinli@hotmail.com>
Re: Add IS_INDEX macro to brin and gist index Andreas Karlsson <andreas@proxel.se>
Re: Add IS_INDEX macro to brin and gist index Japin Li <japinli@hotmail.com>
Re: Add IS_INDEX macro to brin and gist index Kirill Reshke <reshkekirill@gmail.com>

Hi, hackers,

While working on pageinspect [0], I noticed that brin_page_items() and
gist_page_items() only checked the access method (IS_BRIN/IS_GIST) but did
not verify that the passed relation is actually an index relation.

To make the check more robust and consistent with other pageinspect index
functions (like btreefuncs.c, hashfuncs.c, etc.), the attached patch:

1. Defines a local helper macro IS_INDEX(r) in both brinfuncs.c and gistfuncs.c.

2. Updates the error check to require both: the relation must be an index and
   use the expected access method.

The change is very small, low-risk, and only affects two functions in
contrib/pageinspect.

[0]: https://www.postgresql.org/message-id/CALdSSPiN13n7feQcY0WCmq8jzxjwqhNrt1E=g=g6aZANyE_OoQ@mail.gmail.com

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
В списке pgsql-hackers по дате отправления
От: Andreas Karlsson
Дата:
От: Peter Smith
Дата:
FAQ