pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().
Дата
Msg-id
E1u6Ewo-000qPh-1M@gemulon.postgresql.org
Список
Be more wary of corrupt data in pageinspect's heap_page_items().

The original intent in heap_page_items() was to return nulls, not
throw an error or crash, if an item was sufficiently corrupt that
we couldn't safely extract data from it.  However, commit d6061f83a
utterly missed that memo, and not only put in an un-length-checked
copy of the tuple's data section, but also managed to break the check
on sane nulls-bitmap length.  Either mistake could possibly lead to
a SIGSEGV crash if the tuple is corrupt.

Bug: #18896
Reported-by: Dmitry Kovalenko 
Author: Dmitry Kovalenko 
Reviewed-by: Tom Lane 
Discussion: https://postgr.es/m/18896-add267b8e06663e3@postgresql.org
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d05996340d7a4bc32c464be085727ccddf28376b

Modified Files
--------------
contrib/pageinspect/heapfuncs.c | 45 ++++++++++++++++++++++++-----------------
1 file changed, 27 insertions(+), 18 deletions(-)

В списке pgsql-committers по дате отправления
От: Michael Paquier
Дата:
От: Michael Paquier
Дата:
FAQ