Re: [POC] Allow flattening of subquery with a link to upper query
От
Zhihong Yu
Тема
Re: [POC] Allow flattening of subquery with a link to upper query
Дата
Msg-id
CALNJ-vTa5VgvV1NPRHnypdnbx-fhDu7vWp73EkMUbZRpNHTYQQ@mail.gmail.com
Список
Дерево обсуждения
[POC] Allow flattening of subquery with a link to upper query Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Re: [POC] Allow flattening of subquery with a link to upper query Richard Guo <guofenglinux@gmail.com>
Re: [POC] Allow flattening of subquery with a link to upper query Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Re: [POC] Allow flattening of subquery with a link to upper query David Rowley <dgrowleyml@gmail.com>
Re: [POC] Allow flattening of subquery with a link to upper query Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Re: [POC] Allow flattening of subquery with a link to upper query Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Re: [POC] Allow flattening of subquery with a link to upper query Richard Guo <guofenglinux@gmail.com>
Re: [POC] Allow flattening of subquery with a link to upper query Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Re: [POC] Allow flattening of subquery with a link to upper query Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Re: [POC] Allow flattening of subquery with a link to upper query Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Hi,
For contain_placeholders():
+ if (IsA(node, Query))
+ return query_tree_walker((Query *) node, contain_placeholders, context, 0);
+ else if (IsA(node, PlaceHolderVar))
+ return query_tree_walker((Query *) node, contain_placeholders, context, 0);
+ else if (IsA(node, PlaceHolderVar))
The `else` is not needed.
For correlated_t struct, it would be better if the fields have comments.
+ * (for grouping, as an example). So, revert its status to
+ * a full valued entry.
+ * a full valued entry.
full valued -> fully valued
Cheers
В списке pgsql-hackers по дате отправления
От: David Rowley
Дата: