Re: psql tab auto-complete for CREATE PUBLICATION

On Fri, Jul 9, 2021 at 1:06 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> I found that the psql tab auto-complete was not working for some cases
> of CREATE PUBLICATION [1].
>
> CREATE PUBLICATION name
>     [ FOR TABLE [ ONLY ] table_name [ * ] [, ...]
>       | FOR ALL TABLES ]
>     [ WITH ( publication_parameter [= value] [, ... ] ) ]
>
> ~~~
>
> For example, the following scenarios did not work as I was expecting:
>
> "create publication mypub for all tables " TAB --> expected complete
> with "WITH ("
>
> "create publication mypub for all ta" TAB --> expected complete with "TABLES"
>
> "create publication mypub for all tables w" TAB --> expected complete
> with "WITH ("
>
> "create publication mypub for table mytable " TAB --> expected
> complete with "WITH ("
>
> ~~~
>
> PSA a small patch which seems to improve at least for those
> aforementioned cases.
>
> Now results are:
>
> "create publication mypub for all tables " TAB --> "create publication
> mypub for all tables WITH ( "
>
> "create publication mypub for all ta" TAB --> "create publication
> mypub for all tables "
>
> "create publication mypub for all tables w" TAB --> "create
> publication mypub for all tables with ( "
>
> "create publication mypub for table mytable " TAB --> "create
> publication mypub for table mytable WITH ( "
>

Thanks for the patch, the changes look good to me.

Regards,
Vignesh