Re: pgadmin_page functions updated

Поиск
Список
Период
Сортировка
Искать
От
Shubham Agarwal
Тема
Re: pgadmin_page functions updated
Дата
Msg-id
CAKbCA9Q2Dyr7UAt6b6trk-7C2_088G2nBKznOh2gZVB2CndPSQ@mail.gmail.com
Ответ на
Re: pgadmin_page functions updated (Khushboo Vashi)
Список
Дерево обсуждения
pgadmin_page functions updated Shubham Agarwal <shubham.agarwal@enterprisedb.com>
Re: pgadmin_page functions updated Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Re: pgadmin_page functions updated Dave Page <dpage@pgadmin.org>
Re: pgadmin_page functions updated Shubham Agarwal <shubham.agarwal@enterprisedb.com>
Re: pgadmin_page functions updated Dave Page <dpage@pgadmin.org>
Re: pgadmin_page functions updated Shubham Agarwal <shubham.agarwal@enterprisedb.com>
Hi Khushboo,

Yes i agree, currently we are not changing the functions that are already written but will use css selectors in all the upcoming new test cases.

Thanks and regards,
Shubham Agarwal

On Fri, Jun 15, 2018 at 11:02 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Shubham,

On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:
Hi Team,

I have modified following two functions in pgadmin_page.py :-

1. click_tab() -> Added wait till element is clickable, test cases are failing since the function attempts to click the tab which is not yet in the state to be clicked.

2. add_server() -> Replaced the sleep statement with wait till element to be clickable. 

Please find the attached patch.

We should start using CSS selectors instead of xpath, otherwise the patch works fine and also changes look good to me.
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company




--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company
В списке pgadmin-hackers по дате отправления
Предыдущее
От: Khushboo Vashi
Дата:
Следующее
От: Akshay Joshi
Дата:
FAQ