Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

Поиск
Список
Период
Сортировка
Искать
От
Fujii Masao
Тема
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Дата
в 04:38:54
Msg-id
CAHGQGwE7NZJUdvOPg40hYNRcnS=UMohLBtf83W3PRDy1vFXV0A@mail.gmail.com
Ответ на
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks (Michael Paquier)
Список
Дерево обсуждения
[PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks JoongHyuk Shin <sjh910805@gmail.com>
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Greg Lamberson <greg@lamco.io>
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Fujii Masao <masao.fujii@gmail.com>
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Fujii Masao <masao.fujii@gmail.com>
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks JoongHyuk Shin <sjh910805@gmail.com>
Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks Fujii Masao <masao.fujii@gmail.com> 
On Tue, Jul 7, 2026 at 3:59 PM Michael Paquier  wrote:
>
> On Tue, Jul 07, 2026 at 12:01:59PM +0900, JoongHyuk Shin wrote:
> > Attached v8 with the errhint removed.  No other changes from v7.

We can remove assign_recovery_target_name()? With the v8 patch, it only
assigns the GUC string pointer to recoveryTargetName. It seems we could
instead have recovery_target_name store its value directly in
recoveryTargetName, remove recovery_target_name_string, and drop
the assign hook altogether. Thoughts?


> Please note that Fujii-san is registered as a committer of this patch,
> so I am not planning to go beyond a review here.

Thanks for the review! Yes, I will handle this patch.

Regards,

-- 
Fujii Masao
В списке pgsql-hackers по дате отправления
Предыдущее
От: Richard Guo
Дата:
Следующее
От: Michael Paquier
Дата:
FAQ